From: Sean Whitton <spwhitton@spwhitton.name>
Date: Wed, 25 Sep 2024 15:02:53 +0000 (+0100)
Subject: remember-data-file: Don't unconditionally call set-visited-file-name
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=297bb7748e9aeace037d2c50e6461252e63b7dcc;p=emacs.git

remember-data-file: Don't unconditionally call set-visited-file-name

* lisp/textmodes/remember.el (remember-data-file): Don't
unconditionally call set-visited-file-name.

(cherry picked from commit 794bb2a2e31f3027e1db9e027af28151f11a32ed)
---

diff --git a/lisp/textmodes/remember.el b/lisp/textmodes/remember.el
index c75a9b758e7..cc3496da33c 100644
--- a/lisp/textmodes/remember.el
+++ b/lisp/textmodes/remember.el
@@ -378,8 +378,15 @@ exists) might be changed."
            (set-default symbol value)
            (when (buffer-live-p buf)
              (with-current-buffer buf
-               (set-visited-file-name
-                (expand-file-name remember-data-file))))))
+               ;; Don't unconditionally call `set-visited-file-name'
+               ;; because that will probably change the major mode and
+               ;; rename the buffer.
+               ;; These must be avoided in the case where
+               ;; `remember-notes-buffer-name' is "*scratch*", a
+               ;; supported configuration.
+               (let ((value (expand-file-name value)))
+                 (unless (string= buffer-file-name value)
+                   (set-visited-file-name value)))))))
   :initialize #'custom-initialize-default)
 
 (defcustom remember-leader-text "** "