From: Manuel Giraud <manuel@ledu-giraud.fr>
Date: Thu, 3 Mar 2022 16:32:13 +0000 (+0100)
Subject: Fix bookmark-bmenu-list sorting.
X-Git-Tag: emacs-29.0.90~1977
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=29157a9f88c957f26f29284a71dad63d70d40cfd;p=emacs.git

Fix bookmark-bmenu-list sorting.

Do not sort bookmarks in `bookmark-bmenu-list' if `bookmark-sort-flag'
is nil.

Also, make the default order of bookmark-bmenu-list be the LIFO order
defined in `bookmark-sort-flag's documentation.
---

diff --git a/lisp/bookmark.el b/lisp/bookmark.el
index 27517318171..80fb1cdfc78 100644
--- a/lisp/bookmark.el
+++ b/lisp/bookmark.el
@@ -1819,7 +1819,7 @@ Don't affect the buffer ring order."
                        (list location))])
               entries)))
     (tabulated-list-init-header)
-    (setq tabulated-list-entries entries))
+    (setq tabulated-list-entries (reverse entries)))
   (tabulated-list-print t))
 
 ;;;###autoload
@@ -1907,7 +1907,8 @@ Bookmark names preceded by a \"*\" have annotations.
           ,@(if bookmark-bmenu-toggle-filenames
                 '(("File" 0 bookmark-bmenu--file-predicate)))])
   (setq tabulated-list-padding bookmark-bmenu-marks-width)
-  (setq tabulated-list-sort-key '("Bookmark" . nil))
+  (when bookmark-sort-flag
+    (setq tabulated-list-sort-key '("Bookmark" . nil)))
   (add-hook 'tabulated-list-revert-hook #'bookmark-bmenu--revert nil t)'
   (setq revert-buffer-function 'bookmark-bmenu--revert)
   (tabulated-list-init-header))