From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Mon, 12 Apr 2021 02:27:25 +0000 (-0400)
Subject: * lisp/vc/log-edit.el (log-edit-diff-function): Give non-nil default
X-Git-Tag: emacs-28.0.90~2898
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=28a5932e745faee66ce7b23f4c102d29083519e7;p=emacs.git

* lisp/vc/log-edit.el (log-edit-diff-function): Give non-nil default

(log-edit-show-diff): Simplify accordingly.
---

diff --git a/lisp/vc/log-edit.el b/lisp/vc/log-edit.el
index 56b31662210..eabbaba32c0 100644
--- a/lisp/vc/log-edit.el
+++ b/lisp/vc/log-edit.el
@@ -191,7 +191,8 @@ when this variable is set to nil.")
 (defconst log-edit-files-buf "*log-edit-files*")
 (defvar log-edit-initial-files nil)
 (defvar log-edit-callback nil)
-(defvar log-edit-diff-function nil)
+(defvar log-edit-diff-function
+  (lambda () (error "Diff functionality has not been setup")))
 (defvar log-edit-listfun nil)
 
 (defvar log-edit-parent-buffer nil)
@@ -659,9 +660,7 @@ Also saves its contents in the comment history and hides
 (defun log-edit-show-diff ()
   "Show the diff for the files to be committed."
   (interactive)
-  (if (functionp log-edit-diff-function)
-      (funcall log-edit-diff-function)
-    (error "Diff functionality has not been setup")))
+  (funcall log-edit-diff-function))
 
 (defun log-edit-show-files ()
   "Show the list of files to be committed."