From: Tassilo Horn Date: Fri, 15 May 2020 20:24:29 +0000 (+0200) Subject: Consider face inheritance when checking region face background. X-Git-Tag: emacs-27.1-rc1~126 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=28541674cdff8e4d1587391ac66818c56885f083;p=emacs.git Consider face inheritance when checking region face background. Some themes (like dracula) make the region face inherit from some other face. If the background color of the region was inherited, `indicate-copied-region' did the switch-point-and-mark-twice dance which is not visible in case the region is highlighted. It just looked like Emacs would hang for a second after M-w. * lisp/simple.el (indicate-copied-region): Consider face inheritance when checking region face background. --- diff --git a/lisp/simple.el b/lisp/simple.el index ab277c4e115..e8bf77c7e6a 100644 --- a/lisp/simple.el +++ b/lisp/simple.el @@ -4852,7 +4852,7 @@ of this sample text; it defaults to 40." ;; Swap point-and-mark quickly so as to show the region that ;; was selected. Don't do it if the region is highlighted. (unless (and (region-active-p) - (face-background 'region)) + (face-background 'region nil t)) ;; Swap point and mark. (set-marker (mark-marker) (point) (current-buffer)) (goto-char mark)