From: Augusto Stoffel <arstoffel@gmail.com>
Date: Wed, 13 Jan 2021 18:43:08 +0000 (+0100)
Subject: Use `path-separator', not ":",  in eclipse/jdt custom code
X-Git-Tag: emacs-29.0.90~1616^2~524^2~4^2~185
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=26b10c6dafd126d347fa1f835dc9a974953e3282;p=emacs.git

Use `path-separator', not ":",  in eclipse/jdt custom code

This is needed on Windows.

* eglot.el (eglot--eclipse-jdt-contact): Replace literal ":" by `path-separator'.

GitHub-reference: fix https://github.com/joaotavora/eglot/issues/513
---

diff --git a/lisp/progmodes/eglot.el b/lisp/progmodes/eglot.el
index 6d51fc74fc2..b8db7f9057f 100644
--- a/lisp/progmodes/eglot.el
+++ b/lisp/progmodes/eglot.el
@@ -2693,8 +2693,8 @@ If INTERACTIVE, prompt user for details."
               "org\\.eclipse\\.equinox\\.launcher_.*\\.jar$"
               (file-name-nondirectory path))
              (file-exists-p path))))
-    (let* ((classpath (or (getenv "CLASSPATH") ":"))
-           (cp-jar (cl-find-if #'is-the-jar (split-string classpath ":")))
+    (let* ((classpath (or (getenv "CLASSPATH") path-separator))
+           (cp-jar (cl-find-if #'is-the-jar (split-string classpath path-separator)))
            (jar cp-jar)
            (dir
             (cond
@@ -2732,7 +2732,7 @@ If INTERACTIVE, prompt user for details."
       (when (and interactive (not cp-jar)
                  (y-or-n-p (concat "Add path to the server program "
                                    "to CLASSPATH environment variable?")))
-        (setenv "CLASSPATH" (concat (getenv "CLASSPATH") ":" jar)))
+        (setenv "CLASSPATH" (concat (getenv "CLASSPATH") path-separator jar)))
       (unless (file-directory-p workspace)
         (make-directory workspace t))
       (cons 'eglot-eclipse-jdt