From: Glenn Morris <rgm@gnu.org>
Date: Wed, 11 Jan 2017 19:35:51 +0000 (-0500)
Subject: Convert some network test failures to skipping
X-Git-Tag: emacs-26.0.90~909
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=255f675d890b7fa2dc97a40dc03e82fa95b22e65;p=emacs.git

Convert some network test failures to skipping

These tests intermittently fail on hydra.nixos.org for unclear
reasons related to starting the external process.
This isn't an Emacs issue, and the failures cause noise on
the emacs-buildstatus list.  (Bug#24503)
* test/lisp/net/network-stream-tests.el (echo-server-nowait)
(connect-to-tls-ipv4-nowait): Skip rather than fail if the
external process fails to start properly.
---

diff --git a/test/lisp/net/network-stream-tests.el b/test/lisp/net/network-stream-tests.el
index b237fea3dd1..e7bb3e8ccf9 100644
--- a/test/lisp/net/network-stream-tests.el
+++ b/test/lisp/net/network-stream-tests.el
@@ -152,7 +152,7 @@
     (while (and (eq (process-status proc) 'connect)
                 (< (setq times (1+ times)) 10))
       (sit-for 0.1))
-    (should-not (eq (process-status proc) 'connect))
+    (skip-unless (not (eq (process-status proc) 'connect)))
     (with-current-buffer (process-buffer proc)
       (process-send-string proc "echo foo")
       (sleep-for 0.1)
@@ -240,7 +240,7 @@
           (while (and (eq (process-status proc) 'connect)
                       (< (setq times (1+ times)) 10))
             (sit-for 0.1))
-          (should-not (eq (process-status proc) 'connect)))
+          (skip-unless (not (eq (process-status proc) 'connect))))
       (if (process-live-p server) (delete-process server)))
     (setq status (gnutls-peer-status proc))
     (should (consp status))