From: Lars Ingebrigtsen <larsi@gnus.org>
Date: Thu, 12 Apr 2018 22:11:47 +0000 (+0200)
Subject: (dom-texts): Don't return contents of <script> as text
X-Git-Tag: emacs-27.0.90~5271
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=254f5021aa75c161c964bd5f31b957d69814f38f;p=emacs.git

(dom-texts): Don't return contents of <script> as text

From: Lars Ingebrigtsen <larsi@gnus.org>

* lisp/dom.el (dom-texts): Don't return contents of <script> as
text, because it isn't and makes reasoning about textual parts
more difficult.
---

diff --git a/lisp/dom.el b/lisp/dom.el
index 8750d7fa866..6045a68d14c 100644
--- a/lisp/dom.el
+++ b/lisp/dom.el
@@ -78,15 +78,21 @@ A typical attribute is `href'."
 
 (defun dom-texts (node &optional separator)
   "Return all textual data under NODE concatenated with SEPARATOR in-between."
-  (mapconcat
-   'identity
-   (mapcar
-    (lambda (elem)
-      (if (stringp elem)
-	  elem
-	(dom-texts elem separator)))
-    (dom-children node))
-   (or separator " ")))
+  (if (eq (dom-tag node) 'script)
+      ""
+    (mapconcat
+     'identity
+     (mapcar
+      (lambda (elem)
+        (cond
+         ((stringp elem)
+	  elem)
+         ((eq (dom-tag elem) 'script)
+          "")
+         (t
+	  (dom-texts elem separator))))
+      (dom-children node))
+     (or separator " "))))
 
 (defun dom-child-by-tag (dom tag)
   "Return the first child of DOM that is of type TAG."