From: John Williams <jrw@pobox.com>
Date: Thu, 12 Oct 2017 23:02:39 +0000 (-0700)
Subject: Test that advice doesn't trigger bytecomp warnings (Bug#28803)
X-Git-Tag: emacs-26.0.91~494
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=237e96bc5259e59ac5623a93a47f64abffab4e0b;p=emacs.git

Test that advice doesn't trigger bytecomp warnings (Bug#28803)

* test/lisp/emacs-lisp/bytecomp-tests.el
(bytecomp-tests--test-no-warnings-with-advice): New test.

Copyright-paperwork-exempt: yes
---

diff --git a/test/lisp/emacs-lisp/bytecomp-tests.el b/test/lisp/emacs-lisp/bytecomp-tests.el
index 30d2a4753cf..f508c365427 100644
--- a/test/lisp/emacs-lisp/bytecomp-tests.el
+++ b/test/lisp/emacs-lisp/bytecomp-tests.el
@@ -564,6 +564,17 @@ and will be removed soon.  See (elisp)Backquote in the manual.")))))))
     (byte-compile-file source t)
     (should (equal bytecomp-tests--foobar (cons 1 2)))))
 
+(ert-deftest bytecomp-tests--test-no-warnings-with-advice ()
+  (defun f ())
+  (define-advice f (:around (oldfun &rest args) test)
+    (apply oldfun args))
+  (with-current-buffer (get-buffer-create "*Compile-Log*")
+    (let ((inhibit-read-only t)) (erase-buffer)))
+  (test-byte-comp-compile-and-load t '(defun f ()))
+  (with-current-buffer (get-buffer-create "*Compile-Log*")
+    (goto-char (point-min))
+    (should-not (search-forward "Warning" nil t))))
+
 ;; Local Variables:
 ;; no-byte-compile: t
 ;; End: