From: Ɓukasz Stelmach Date: Tue, 22 Dec 2020 06:47:23 +0000 (+0100) Subject: Handle gracefully href="" in base tags in shr X-Git-Tag: emacs-28.0.90~4607 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=1e11f6f59d141f280b50905238a392faffdb134a;p=emacs.git Handle gracefully href="" in base tags in shr * net/shr.el (shr-tag-base): shr-parse-base can't handle empty strings gracefully. Don't call it unless href is a non-empty string (bug#45355). --- diff --git a/lisp/net/shr.el b/lisp/net/shr.el index 2e5dd5ffa50..1648e56cfb4 100644 --- a/lisp/net/shr.el +++ b/lisp/net/shr.el @@ -1516,8 +1516,9 @@ ones, in case fg and bg are nil." plist))) (defun shr-tag-base (dom) - (when-let* ((base (dom-attr dom 'href))) - (setq shr-base (shr-parse-base base))) + (let ((base (dom-attr dom 'href))) + (when (> (length base) 0) + (setq shr-base (shr-parse-base base)))) (shr-generic dom)) (defun shr-tag-a (dom)