From: Xi Lu <lx@shellcodes.org>
Date: Sat, 24 Dec 2022 08:28:54 +0000 (+0800)
Subject: Fix htmlfontify.el command injection vulnerability.
X-Git-Tag: emacs-29.0.90~967
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=1b4dc4691c1f87fc970fbe568b43869a15ad0d4c;p=emacs.git

Fix htmlfontify.el command injection vulnerability.

* lisp/htmlfontify.el (hfy-text-p): Fix command injection
vulnerability.  (Bug#60295)
---

diff --git a/lisp/htmlfontify.el b/lisp/htmlfontify.el
index df4c6ab079c..389b92939cc 100644
--- a/lisp/htmlfontify.el
+++ b/lisp/htmlfontify.el
@@ -1850,7 +1850,7 @@ Hardly bombproof, but good enough in the context in which it is being used."
 
 (defun hfy-text-p (srcdir file)
   "Is SRCDIR/FILE text?  Use `hfy-istext-command' to determine this."
-  (let* ((cmd (format hfy-istext-command (expand-file-name file srcdir)))
+  (let* ((cmd (format hfy-istext-command (shell-quote-argument (expand-file-name file srcdir))))
          (rsp (shell-command-to-string    cmd)))
     (string-match "text" rsp)))