From: Daniel Colascione <dancol@dancol.org>
Date: Wed, 4 Mar 2020 02:27:51 +0000 (-0800)
Subject: Ignore spurious focus events
X-Git-Tag: emacs-28.0.90~7804
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=1aa8780d7b3bf0b4dd227946f0c6095b2c9e545e;p=emacs.git

Ignore spurious focus events

* src/xterm.c (x_detect_focus_change): Ignore FocusIn and FocusOut
events from grabs
---

diff --git a/src/xterm.c b/src/xterm.c
index 21d99f0c7bb..5d229e4f524 100644
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -4790,6 +4790,16 @@ x_detect_focus_change (struct x_display_info *dpyinfo, struct frame *frame,
 
     case FocusIn:
     case FocusOut:
+      /* Ignore transient focus events from hotkeys, window manager
+         gadgets, and other odd sources.  Some buggy window managers
+         (e.g., Muffin 4.2.4) send FocusIn events of this type without
+         corresponding FocusOut events even when some other window
+         really has focus, and these kinds of focus event don't
+         correspond to real user input changes.  GTK+ uses the same
+         filtering. */
+      if (event->xfocus.mode == NotifyGrab ||
+          event->xfocus.mode == NotifyUngrab)
+        return;
       x_focus_changed (event->type,
 		       (event->xfocus.detail == NotifyPointer ?
 			FOCUS_IMPLICIT : FOCUS_EXPLICIT),