From: Khaled Hosny Date: Mon, 24 Dec 2018 02:00:04 +0000 (+0200) Subject: Clarify one FIXME a bit X-Git-Tag: emacs-27.0.90~2671^2~33 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=1a80b5d9b8cfa0e523b596db5d1e7e6074dbee46;p=emacs.git Clarify one FIXME a bit --- diff --git a/src/ftfont.c b/src/ftfont.c index bc37a6ae0d1..74d72f94abd 100644 --- a/src/ftfont.c +++ b/src/ftfont.c @@ -2850,8 +2850,8 @@ ftfont_shape_by_hb (Lisp_Object lgstring, FT_Face ft_face, hb_font_t *hb_font, return Qnil; glyph_len = hb_buffer_get_length (hb_buffer); - /* FIXME: number of output glyphs can legitimately be larger than number of - * output characters, what to do in this case? */ + /* FIXME: can't we just grew the lgstring in this case? Givving up is an + * overly heavy handed solution. */ if (glyph_len > LGSTRING_GLYPH_LEN (lgstring)) return Qnil;