From: F. Jason Park <jp@neverwas.me>
Date: Wed, 28 Dec 2022 14:18:01 +0000 (-0800)
Subject: Avoid "already compiled" warning in erc-compat
X-Git-Tag: emacs-29.0.90~949
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=19d00fab9aaf28dae6af5786f6e22b8558b10eea;p=emacs.git

Avoid "already compiled" warning in erc-compat

* lisp/erc/erc-compat.el (erc-compat--29-auth-source-pass-search):
Don't `byte-compile' sub-29 secrets wrapper.  This was especially
noisy in tests.  Ditch closed-over vars via HOF instead of suppressing
because compiling emits "unused lexical" warning on Emacs 27.
---

diff --git a/lisp/erc/erc-compat.el b/lisp/erc/erc-compat.el
index fdcb146d42a..864c5882cf2 100644
--- a/lisp/erc/erc-compat.el
+++ b/lisp/erc/erc-compat.el
@@ -261,7 +261,7 @@ If START or END is negative, it counts from the end."
             (when-let* ((s (plist-get e :secret))
                         (v (auth-source--obfuscate s)))
               (setf (plist-get e :secret)
-                    (byte-compile (lambda () (auth-source--deobfuscate v)))))
+                    (apply-partially #'auth-source--deobfuscate v)))
             (push e out)))
       rv)))