From: João Távora <joaotavora@gmail.com>
Date: Wed, 25 Dec 2019 19:18:17 +0000 (+0000)
Subject: Don't always resort in recently introduced icomplete--sorted-completions
X-Git-Tag: emacs-27.0.90~236
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=195bde9ea82e7bc62d7242bcf089ef3d181020f1;p=emacs.git

Don't always resort in recently introduced icomplete--sorted-completions

Doing so breaks icomplete-forward-completions and
icomplete-backward-completions.

* lisp/icomplete.el (icomplete--sorted-completions): Don't always
resort.

(cherry picked from commit 639fb50ed4c622f99dfbde32fbdbca42ce36d385)
---

diff --git a/lisp/icomplete.el b/lisp/icomplete.el
index 3b3cabb890e..6bc75b39edb 100644
--- a/lisp/icomplete.el
+++ b/lisp/icomplete.el
@@ -442,36 +442,37 @@ Usually run by inclusion in `minibuffer-setup-hook'."
     (add-hook 'post-command-hook 'icomplete-post-command-hook nil t)))
 
 (defun icomplete--sorted-completions ()
-  (cl-loop
-   with beg = (icomplete--field-beg)
-   with end = (icomplete--field-end)
-   with all = (completion-all-sorted-completions beg end)
-   for fn in (cond ((and minibuffer-default
-                         (= (icomplete--field-end) (icomplete--field-beg)))
-                    ;; When we have a non-nil default and no input
-                    ;; whatsoever: we want to make sure that default
-                    ;; is bubbled to the top so that
-                    ;; `icomplete-force-complete-and-exit' will
-                    ;; select it (do that even if the match doesn't
-                    ;; match the completion perfectly.
-                    `(,(lambda (comp)
-                         (equal minibuffer-default comp))
-                      ,(lambda (comp)
-                         (string-prefix-p minibuffer-default comp))))
-                   ((and fido-mode
-                         (not minibuffer-default)
-                         (eq (icomplete--category) 'file))
-                    `(,(lambda (comp)
-                         (string= "./" comp)))))
-   thereis (cl-loop
-            for l on all
-            while (consp (cdr l))
-            for comp = (cadr l)
-            when (funcall fn comp)
-            do (setf (cdr l) (cddr l))
-            and return
-            (completion--cache-all-sorted-completions beg end (cons comp all)))
-   finally return all))
+  (or completion-all-sorted-completions
+      (cl-loop
+       with beg = (icomplete--field-beg)
+       with end = (icomplete--field-end)
+       with all = (completion-all-sorted-completions beg end)
+       for fn in (cond ((and minibuffer-default
+                             (= (icomplete--field-end) (icomplete--field-beg)))
+                        ;; When we have a non-nil default and no input
+                        ;; whatsoever: we want to make sure that default
+                        ;; is bubbled to the top so that
+                        ;; `icomplete-force-complete-and-exit' will
+                        ;; select it (do that even if the match doesn't
+                        ;; match the completion perfectly.
+                        `(,(lambda (comp)
+                             (equal minibuffer-default comp))
+                          ,(lambda (comp)
+                             (string-prefix-p minibuffer-default comp))))
+                       ((and fido-mode
+                             (not minibuffer-default)
+                             (eq (icomplete--category) 'file))
+                        `(,(lambda (comp)
+                             (string= "./" comp)))))
+       thereis (cl-loop
+                for l on all
+                while (consp (cdr l))
+                for comp = (cadr l)
+                when (funcall fn comp)
+                do (setf (cdr l) (cddr l))
+                and return
+                (completion--cache-all-sorted-completions beg end (cons comp all)))
+       finally return all)))