From: Mark Oteiza <mvoteiza@udel.edu>
Date: Tue, 13 Oct 2015 18:19:18 +0000 (-0400)
Subject: Fix error messages for when covers are not found.
X-Git-Tag: emacs-25.0.90~1139
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=18b0eb7f1cc16fe33f89c74d2497a6fcb4b863fd;p=emacs.git

Fix error messages for when covers are not found.

The last change to mpc-format let the binding to file call
mpc-file-local-copy with nil argument. Instead, employ if-let here so
nil bindings don't result in needless computation and errors.
* lisp/mpc.el: Require 'subr-x at compile time.
* lisp/mpc.el (mpc-format): Use if-let.
---

diff --git a/lisp/mpc.el b/lisp/mpc.el
index 21002ec5081..063a545da81 100644
--- a/lisp/mpc.el
+++ b/lisp/mpc.el
@@ -91,7 +91,9 @@
 ;; UI-commands       : mpc-
 ;; internal          : mpc--
 
-(eval-when-compile (require 'cl-lib))
+(eval-when-compile
+  (require 'cl-lib)
+  (require 'subr-x))
 
 (defgroup mpc ()
   "Client for the Music Player Daemon (mpd)."
@@ -1008,31 +1010,30 @@ If PLAYLIST is t or nil or missing, use the main playlist."
                                                (substring time (match-end 0))
                                              time)))))
                     (`Cover
-                     (let* ((dir (file-name-directory
-                                  (mpc-file-local-copy (cdr (assq 'file info)))))
-                            (covers '(".folder.png" "cover.jpg" "folder.jpg"))
-                            (cover (cl-loop for file in (directory-files dir)
-                                            if (member (downcase file) covers)
-                                            return (concat dir file)))
-                            (file (with-demoted-errors "MPC: %s"
-                                    (mpc-file-local-copy cover)))
-                            image)
-                       ;; (debug)
-                       (push `(equal ',dir (file-name-directory (cdr (assq 'file info)))) pred)
-                       (if (null file)
-                           ;; Make sure we return something on which we can
-                           ;; place the `mpc-pred' property, as
-                           ;; a negative-cache.  We could also use
-                           ;; a default cover.
-                           (progn (setq size nil) " ")
-                         (if (null size) (setq image (create-image file))
-                           (let ((tempfile (make-temp-file "mpc" nil ".jpg")))
-                             (call-process "convert" nil nil nil
-                                           "-scale" size file tempfile)
-                             (setq image (create-image tempfile))
-                             (mpc-tempfiles-add image tempfile)))
-                         (setq size nil)
-                         (propertize dir 'display image))))
+                     (if-let ((dir (file-name-directory
+                                    (mpc-file-local-copy (cdr (assq 'file info)))))
+                              (covers '(".folder.png" "cover.jpg" "folder.jpg"))
+                              (cover (cl-loop for file in (directory-files dir)
+                                              if (member (downcase file) covers)
+                                              return (concat dir file)))
+                              (file (with-demoted-errors "MPC: %s"
+                                      (mpc-file-local-copy cover))))
+                         (let (image)
+                           ;; (debug)
+                           (push `(equal ',dir (file-name-directory (cdr (assq 'file info)))) pred)
+                           (if (null size) (setq image (create-image file))
+                             (let ((tempfile (make-temp-file "mpc" nil ".jpg")))
+                               (call-process "convert" nil nil nil
+                                             "-scale" size file tempfile)
+                               (setq image (create-image tempfile))
+                               (mpc-tempfiles-add image tempfile)))
+                           (setq size nil)
+                           (propertize dir 'display image))
+                       ;; Make sure we return something on which we can
+                       ;; place the `mpc-pred' property, as
+                       ;; a negative-cache.  We could also use
+                       ;; a default cover.
+                       (progn (setq size nil) " ")))
                     (_ (let ((val (cdr (assq tag info))))
                          ;; For Streaming URLs, there's no other info
                          ;; than the URL in `file'.  Pretend it's in `Title'.