From: Philip Kaludercic Date: Sat, 27 May 2023 08:13:21 +0000 (+0200) Subject: ; Fix 'package-install-upgrade-built-in' check for package menu X-Git-Tag: emacs-29.0.92~67 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=17c7915ab94;p=emacs.git ; Fix 'package-install-upgrade-built-in' check for package menu * lisp/emacs-lisp/package.el (package-menu--find-upgrades): Use correct check to verify if a built-in packages in the package menu can be upgraded or not. This change improves upon a faulty assumption from ba2c76fa2bc3aabfda7d1d09cc5148f3f9d8e08e. (Bug#63587) --- diff --git a/lisp/emacs-lisp/package.el b/lisp/emacs-lisp/package.el index 202aca36f24..8f266186d5e 100644 --- a/lisp/emacs-lisp/package.el +++ b/lisp/emacs-lisp/package.el @@ -3769,8 +3769,8 @@ object corresponding to the newer version." (and avail-pkg (version-list-< (package-desc-priority-version pkg-desc) (package-desc-priority-version avail-pkg)) - (xor (not package-install-upgrade-built-in) - (package--active-built-in-p pkg-desc)) + (or (not (package--active-built-in-p pkg-desc)) + package-install-upgrade-built-in) (push (cons name avail-pkg) upgrades)))) upgrades))