From: John Shahid <jvshahid@gmail.com>
Date: Fri, 4 Jan 2019 21:28:35 +0000 (+0000)
Subject: Unbreak Flymake's diagnostics buffer when revisiting source
X-Git-Tag: emacs-27.0.90~3869
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=16e2554880381d5cef4ec209675c084bc96d09e1;p=emacs.git

Unbreak Flymake's diagnostics buffer when revisiting source

Fixes: bug#33881
Copyright-paperwork-exempt: yes

* lisp/progmodes/flymake.el (flymake-show-diagnostics-buffer):
Set flymake--diagnostics-buffer-source before reverting.
---

diff --git a/lisp/progmodes/flymake.el b/lisp/progmodes/flymake.el
index 50a9880a14e..14940844a42 100644
--- a/lisp/progmodes/flymake.el
+++ b/lisp/progmodes/flymake.el
@@ -1332,9 +1332,9 @@ POS can be a buffer position or a button"
          (target (or (get-buffer name)
                      (with-current-buffer (get-buffer-create name)
                        (flymake-diagnostics-buffer-mode)
-                       (setq flymake--diagnostics-buffer-source source)
                        (current-buffer)))))
     (with-current-buffer target
+      (setq flymake--diagnostics-buffer-source source)
       (revert-buffer)
       (display-buffer (current-buffer)))))