From: Mattias Engdegård <mattiase@acm.org>
Date: Mon, 10 Apr 2023 13:07:24 +0000 (+0200)
Subject: ebnf2ps: eliminate double nreverse
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=119a7dd22084fe20da7b2fddd41a63870da89bda;p=emacs.git

ebnf2ps: eliminate double nreverse

* lisp/progmodes/ebnf-otz.el (ebnf-split-suffix): Simplify code that
relied on a rather inobvious in-place reversal of a list twice for
correctness, silencing a byte-compiler warning.
---

diff --git a/lisp/progmodes/ebnf-otz.el b/lisp/progmodes/ebnf-otz.el
index 9ac37b676f9..4155dc0d2cd 100644
--- a/lisp/progmodes/ebnf-otz.el
+++ b/lisp/progmodes/ebnf-otz.el
@@ -566,7 +566,7 @@
     ;; determine suffix length
     (while (and (> isuf 0) (setq tail (cdr tail)))
       (let* ((cur head)
-	     (tlis (nreverse
+	     (tlis (reverse
 		    (if (eq (ebnf-node-kind (car tail)) 'ebnf-generate-sequence)
 			(ebnf-node-list (car tail))
 		      (list (car tail)))))
@@ -577,7 +577,6 @@
 	  (setq cur  (cdr cur)
 		this (cdr this)
 		i    (1+ i)))
-	(nreverse tlis)
 	(setq isuf (min isuf i))))
     (setq head (nreverse head))
     (if (or (zerop isuf) (> isuf len))