From: Eshel Yaron <me@eshelyaron.com>
Date: Sun, 4 Feb 2024 12:57:06 +0000 (+0100)
Subject: ; Fix remote shell file name selection
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=11562ddbde3962a43701ea4d334cffa72e0fe5b1;p=emacs.git

; Fix remote shell file name selection

* lisp/shell.el (shell): Cease providing 'file-remote-p' as completion
predicate when reading remote shell file name.  The completion predicate
in 'read-file-name' gets the non-directory part of the file name, which
in particular does not include the remote part, if any, so this
predicate always fail in these settings.  Moreover, this predicate
didn't make a lot of sense to begin with.
---

diff --git a/lisp/shell.el b/lisp/shell.el
index c5cfbd985ed..b02f5f117a9 100644
--- a/lisp/shell.el
+++ b/lisp/shell.el
@@ -905,8 +905,7 @@ Make the shell buffer the current buffer, and return it.
             (file-local-name
              (expand-file-name
               (read-file-name "Remote shell path: " default-directory
-                              shell-file-name t shell-file-name
-                              #'file-remote-p))))))))))
+                              shell-file-name t shell-file-name))))))))))
 
   (setq buffer (if (or buffer (not (derived-mode-p 'shell-mode))
                        (comint-check-proc (current-buffer)))