From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Thu, 14 Jul 2016 13:45:05 +0000 (-0400)
Subject: * lisp/simple.el (shell-command): Add save-match-data comment
X-Git-Tag: emacs-26.0.90~1840^2~55
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=0ea47a6159f351f32b7dbc68debe99eb02f2dd8d;p=emacs.git

* lisp/simple.el (shell-command): Add save-match-data comment
---

diff --git a/lisp/simple.el b/lisp/simple.el
index 6d7f00f52f4..a757876328b 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -3328,6 +3328,8 @@ the use of a shell (with its need to quote arguments)."
 				     (current-buffer)))))
 	;; Output goes in a separate buffer.
 	;; Preserve the match data in case called from a program.
+        ;; FIXME: It'd be ridiculous for an Elisp function to call
+        ;; shell-command and assume that it won't mess the match-data!
 	(save-match-data
 	  (if (string-match "[ \t]*&[ \t]*\\'" command)
 	      ;; Command ending with ampersand means asynchronous.