From: Eli Zaretskii <eliz@gnu.org>
Date: Thu, 1 Sep 2016 17:15:25 +0000 (+0300)
Subject: * nt/inc/ms-w32.h (execve) [MINGW_W64]: Make commentary more accurate.
X-Git-Tag: emacs-26.0.90~1659
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=0c94b847082bf915137c4270b8009ad599681ccf;p=emacs.git

* nt/inc/ms-w32.h (execve) [MINGW_W64]: Make commentary more accurate.
---

diff --git a/nt/inc/ms-w32.h b/nt/inc/ms-w32.h
index 12cd0810054..8e3a8c2c226 100644
--- a/nt/inc/ms-w32.h
+++ b/nt/inc/ms-w32.h
@@ -294,11 +294,12 @@ extern int sys_umask (int);
 #include <stdint.h>		/* for intptr_t */
 extern intptr_t _execvp (const char *, char **);
 #ifdef MINGW_W64
-/* MinGW64 GCC 6 has a builtin execve with the prototype shown below.
-   The return value is wrong, and is a bug in GCC, but using the
-   correct prototype causes GCC to emit warnings.  Fortunately, execve
-   is not used in the MinGW build, but the code that references it is
-   still compiled.  */
+/* GCC 6 has a builtin execve with the prototype shown below.  MinGW64
+   changed the prototype in its process.h to match that, although the
+   library function still calls _execve, which still returns intptr_t.
+   However, using the prototype with intptr_t causes GCC to emit
+   warnings.  Fortunately, execve is not used in the MinGW build, but
+   the code that references it is still compiled.  */
 extern int execve (const char *, char * const *, char * const *);
 #else
 extern intptr_t execve (const char *, char * const *, char * const *);