From: Po Lu <luangruo@yahoo.com>
Date: Wed, 5 Jul 2023 12:16:14 +0000 (+0800)
Subject: Fix bug#64445
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=08f90dc0058df25d7b405a8f9fca3dad638db44a;p=emacs.git

Fix bug#64445

* doc/emacs/android.texi (Android Environment): Document that
Emacs also receives READ_EXTERNAL_STORAGE by default on old
versions of Android.
* java/AndroidManifest.xml.in: Request READ_EXTERNAL_STORAGE.
(bug#64445)
---

diff --git a/doc/emacs/android.texi b/doc/emacs/android.texi
index 85719da518a..3e27c019257 100644
--- a/doc/emacs/android.texi
+++ b/doc/emacs/android.texi
@@ -382,6 +382,8 @@ permissions it has requested upon being installed:
 @item
 @code{android.permission.SET_WALLPAPER}
 @item
+@code{android.permission.READ_EXTERNAL_STORAGE}
+@item
 @code{android.permission.WRITE_EXTERNAL_STORAGE}
 @item
 @code{android.permission.SEND_SMS}
diff --git a/java/AndroidManifest.xml.in b/java/AndroidManifest.xml.in
index 082c4c9373e..e79fb4e46e7 100644
--- a/java/AndroidManifest.xml.in
+++ b/java/AndroidManifest.xml.in
@@ -38,6 +38,11 @@ along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>. -->
   <uses-permission android:name="android.permission.ACCESS_NETWORK_STATE" />
   <uses-permission android:name="android.permission.INTERNET" />
   <uses-permission android:name="android.permission.SET_WALLPAPER" />
+  <!-- Despite the claim that WRITE_EXTERNAL_STORAGE also covers
+       reading from external storage, specifying READ_EXTERNAL_STORAGE
+       seems to still be necessary on some versions of Android.
+       (bug#64445) -->
+  <uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" />
   <uses-permission android:name="android.permission.WRITE_EXTERNAL_STORAGE" />
   <uses-permission android:name="android.permission.SEND_SMS" />
   <uses-permission android:name="android.permission.RECEIVE_SMS" />