From: Glenn Morris Date: Tue, 21 Feb 2017 02:08:48 +0000 (-0800) Subject: ; Add a new TODO item X-Git-Tag: emacs-26.0.90~752 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=08c73cdc6e2436473b467e207c1a713bb271da11;p=emacs.git ; Add a new TODO item * etc/TODO: Add a new entry for :set-after. * lisp/startup.el: Related comment. --- diff --git a/etc/TODO b/etc/TODO index b102bdf35f0..71704f07cfd 100644 --- a/etc/TODO +++ b/etc/TODO @@ -968,6 +968,17 @@ addition, toolkit builds create their menu bars in toolkit-specific parts of code, bypassing xdisp.c, so those parts need to be enhanced with toolkit-specific code to display the menu bar right to left. +** Custom + +*** Extend :set-after to also mean initialize after. +If defcustom A specifies :set-after '(B), then if a user customizes +both A and B, custom will set A after B. But if the user only customizes +A, then if B is already defined, it gets left at its original setting. +Instead, if B has not been customized it should be re-initialized +(on the assumption that the default value depends on A). +See the places where we manually call custom-reevaluate-setting, +such as for mail-host-address and user-mail-address in startup.el. + ** ImageMagick support *** image-type-header-regexps priorities the jpeg loader over the diff --git a/lisp/startup.el b/lisp/startup.el index 2d48bd5df15..bc60bbd08b8 100644 --- a/lisp/startup.el +++ b/lisp/startup.el @@ -1298,7 +1298,7 @@ the `--debug-init' option to view a complete error backtrace." ;; Yes, this is ugly, but slightly less so than leaving ;; user-mail-address uninitialized during init file processing. ;; Perhaps we should make :set-after do something like this? - ;; Ie, extend it to also mean (re)initialize-after. + ;; Ie, extend it to also mean (re)initialize-after. See etc/TODO. (equal user-mail-address (let (mail-host-address) (ignore-errors