From: Juri Linkov <juri@linkov.net>
Date: Sat, 22 Dec 2018 23:52:25 +0000 (+0200)
Subject: * lisp/simple.el (next-error-no-select): Use save-selected-window.
X-Git-Tag: emacs-27.0.90~3930
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=072b4c679dfd5528e74849cad18246730a991933;p=emacs.git

* lisp/simple.el (next-error-no-select): Use save-selected-window.

Let-bind display alist of display-buffer-overriding-action to
`(inhibit-same-window . t)'.  (Bug#32607)
---

diff --git a/lisp/simple.el b/lisp/simple.el
index 905477a1420..ab4960dc968 100644
--- a/lisp/simple.el
+++ b/lisp/simple.el
@@ -383,13 +383,11 @@ backwards, if negative).
 Finds and highlights the source line like \\[next-error], but does not
 select the source buffer."
   (interactive "p")
-  (let ((next-error-highlight next-error-highlight-no-select))
-    (next-error n))
-  (let ((display-buffer-overriding-action '(display-buffer-reuse-window)))
-    ;; Override user customization such as display-buffer-same-window
-    ;; and use display-buffer-reuse-window to ensure next-error-last-buffer
-    ;; is displayed somewhere, not necessarily in the same window (bug#32607).
-    (pop-to-buffer next-error-last-buffer)))
+  (save-selected-window
+    (let ((next-error-highlight next-error-highlight-no-select)
+          (display-buffer-overriding-action
+           '(nil (inhibit-same-window . t))))
+      (next-error n))))
 
 (defun previous-error-no-select (&optional n)
   "Move point to the previous error in the `next-error' buffer and highlight match.