From: Stefan Kangas Date: Tue, 18 Aug 2020 18:16:06 +0000 (+0200) Subject: Remove the "Recent message" section from the bug reports X-Git-Tag: emacs-28.0.90~6543 X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=070c60665e71ac9dddf073c9c49c1f8e91a9811f;p=emacs.git Remove the "Recent message" section from the bug reports * lisp/mail/emacsbug.el (report-emacs-bug): Don't include "Recent messages" since it has privacy implications. Problem reported by Lars Ingebrigtsen in: https://lists.gnu.org/archive/html/emacs-devel/2019-11/msg01099.html (bug#39185). --- diff --git a/etc/NEWS b/etc/NEWS index c608c612a45..8085f96740f 100644 --- a/etc/NEWS +++ b/etc/NEWS @@ -815,6 +815,11 @@ window after starting). This variable defaults to nil. ** Miscellaneous +--- +*** 'M-x report-emacs-bug' will no longer include "Recent messages" section. +These were taken from the "*Messages*" buffer, and may inadvertently +leak information from the reporting user. + --- *** 'count-windows' now takes an optional parameter ALL-FRAMES. The semantics are as with 'walk-windows'. diff --git a/lisp/mail/emacsbug.el b/lisp/mail/emacsbug.el index efbc0668553..6b9e1db5fc6 100644 --- a/lisp/mail/emacsbug.el +++ b/lisp/mail/emacsbug.el @@ -324,18 +324,6 @@ usually do not have translators for other languages.\n\n"))) (let ((os (ignore-errors (report-emacs-bug--os-description)))) (if (stringp os) (insert "System Description: " os "\n\n"))) - (let ((message-buf (get-buffer "*Messages*"))) - (if message-buf - (let (beg-pos - (end-pos message-end-point)) - (with-current-buffer message-buf - (goto-char end-pos) - (forward-line -10) - (setq beg-pos (point))) - (terpri (current-buffer) t) - (insert "Recent messages:\n") - (insert-buffer-substring message-buf beg-pos end-pos)))) - (insert "\n") (when (and system-configuration-options (not (equal system-configuration-options ""))) (insert "Configured using:\n 'configure "