From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Tue, 31 Mar 2020 16:11:26 +0000 (-0400)
Subject: * lisp/dired.el (dired-readin): Improve comment
X-Git-Tag: emacs-28.0.90~7684
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=05cab7ad06efabae18ee94e3b609ea10ae2f60be;p=emacs.git

* lisp/dired.el (dired-readin): Improve comment
---

diff --git a/lisp/dired.el b/lisp/dired.el
index d58c37be2f9..62e232b79fd 100644
--- a/lisp/dired.el
+++ b/lisp/dired.el
@@ -1226,10 +1226,10 @@ wildcards, erases the buffer, and builds the subdir-alist anew
       ;; We used to bind `inhibit-modification-hooks' to try and speed up
       ;; execution, in particular, to prevent the font-lock hook from running
       ;; until the directory is all read in.
-      ;; I strongly suspect that this was only useful in Emacs<21, because
-      ;; jit-lock made it a non-issue.
-      ;; Nevertheless, I used `combine-change-calls' which provides the
-      ;; same performance advantages, just in case.
+      ;; It's not clear why font-lock would be a significant issue
+      ;; here, but I used `combine-change-calls' which should provide the
+      ;; same performance advantages without the problem of breaking
+      ;; users of after/before-change-functions.
       (combine-change-calls (point-min) (point-max)
 	(let ((inhibit-read-only t)
 	      ;; Don't make undo entries for readin.