From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Wed, 14 Jun 2023 21:06:37 +0000 (-0400)
Subject: Avoid using `(lambda ...) to build function values
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=020fd630184406a4e25f93e1fb2a3df77c6c9db9;p=emacs.git

Avoid using `(lambda ...) to build function values

* lisp/emacs-lisp/nadvice.el (advice-eval-interactive-spec): Avoid
`(lambda ...).
---

diff --git a/lisp/emacs-lisp/nadvice.el b/lisp/emacs-lisp/nadvice.el
index e6977f2012a..cd80df2c41d 100644
--- a/lisp/emacs-lisp/nadvice.el
+++ b/lisp/emacs-lisp/nadvice.el
@@ -176,7 +176,9 @@ DOC is a string where \"FUNCTION\" and \"OLDFUN\" are expected.")
     ;; FIXME: Despite appearances, this is not faithful: SPEC and
     ;; (advice-eval-interactive-spec SPEC) will behave subtly differently w.r.t
     ;; command-history (and maybe a few other details).
-    (call-interactively `(lambda (&rest args) (interactive ,spec) args)))
+    (call-interactively
+     ;; Sadly (lambda (&rest args) (interactive spec) args) doesn't work :-(
+     (cconv--interactive-helper (lambda (&rest args) args) spec)))
    ;; ((functionp spec) (funcall spec))
    (t (eval spec))))