From: Stefan Monnier <monnier@iro.umontreal.ca>
Date: Fri, 12 Mar 2021 03:27:41 +0000 (-0500)
Subject: * lisp/emacs-lisp/cconv.el (cconv--analyze-use): Tune down the warning
X-Git-Tag: emacs-28.0.90~3306
X-Git-Url: http://git.eshelyaron.com/gitweb/?a=commitdiff_plain;h=009bc7c9d8bd0074a78ebef73102f600a514172c;p=emacs.git

* lisp/emacs-lisp/cconv.el (cconv--analyze-use): Tune down the warning

Don't warn for always-nil bindings if the binding is made explicit.
Fixes bug#47080.
---

diff --git a/lisp/emacs-lisp/cconv.el b/lisp/emacs-lisp/cconv.el
index ca641a2ef0c..cfb0168a6e5 100644
--- a/lisp/emacs-lisp/cconv.el
+++ b/lisp/emacs-lisp/cconv.el
@@ -602,7 +602,8 @@ FORM is the parent form that binds this var."
      (byte-compile-warn
       "%s `%S' not left unused" varkind var))
     ((and (let (or 'let* 'let) (car form))
-          `(,(or `(,var) `(,var nil)) t nil ,_ ,_))
+          `(,`(,var) ;; (or `(,var nil) : Too many false positives: bug#47080
+            t nil ,_ ,_))
      ;; FIXME: Convert this warning to use `macroexp--warn-wrap'
      ;; so as to give better position information.
      (unless (not (intern-soft var))