On OSX, do not free font-specific data more than once (Bug#18501).

* macfont.m (macfont_close): Release and free font-specific data
only if it wasn't previously freed.

diff --git a/src/ChangeLog b/src/ChangeLog
index 684de4985225eeb8f2dfe4827e7e9ebcb850655e..4d969d73279426810893eab2044199da533189fe 100644 (file)
--- a/src/ChangeLog
+++ b/src/ChangeLog
@@ -1,3 +1,9 @@
+2014-09-22  Dmitry Antipov  <dmantipov@yandex.ru>
+
+       On OSX, do not free font-specific data more than once (Bug#18501).
+       * macfont.m (macfont_close): Release and free font-specific data
+       only if it wasn't previously freed.
+
 2014-09-21  David Caldwell <david@porkrind.org> (tiny change)
 
        * unexmacosx.c (dump_it): Improve error message.

diff --git a/src/macfont.m b/src/macfont.m
index 1bb3fb141349b184045832225cf6f9920beb0d26..69bde9f66a7dca67e9a011598eafea8f72427e85 100644 (file)
--- a/src/macfont.m
+++ b/src/macfont.m
@@ -2616,20 +2616,25 @@ static void
 macfont_close (struct font *font)
 {
   struct macfont_info *macfont_info = (struct macfont_info *) font;
-  int i;
 
-  block_input ();
-  CFRelease (macfont_info->macfont);
-  CGFontRelease (macfont_info->cgfont);
-  if (macfont_info->screen_font)
-    CFRelease (macfont_info->screen_font);
-  macfont_release_cache (macfont_info->cache);
-  for (i = 0; i < macfont_info->metrics_nrows; i++)
-    if (macfont_info->metrics[i])
-      xfree (macfont_info->metrics[i]);
-  if (macfont_info->metrics)
-    xfree (macfont_info->metrics);
-  unblock_input ();
+  if (macfont_info->cache)
+    {
+      int i;
+
+      block_input ();
+      CFRelease (macfont_info->macfont);
+      CGFontRelease (macfont_info->cgfont);
+      if (macfont_info->screen_font)
+       CFRelease (macfont_info->screen_font);
+      macfont_release_cache (macfont_info->cache);
+      for (i = 0; i < macfont_info->metrics_nrows; i++)
+       if (macfont_info->metrics[i])
+         xfree (macfont_info->metrics[i]);
+      if (macfont_info->metrics)
+       xfree (macfont_info->metrics);
+      macfont_info->cache = NULL;
+      unblock_input ();
+    }
 }
 
 static int