Fix replying to _NET_WM_PING during drag-and-drop

* src/xterm.c (handle_one_xevent): Test client window against
root window instead of using nonstandard event mask.

diff --git a/src/xterm.c b/src/xterm.c
index 0ebabdccafda441d2c3ede525a2978fa1e102564..fb7d18a53fbfe8076ed3a17127e4e21dd7a4b30d 100644 (file)
--- a/src/xterm.c
+++ b/src/xterm.c
@@ -15246,25 +15246,23 @@ handle_one_xevent (struct x_display_info *dpyinfo,
 
 
            if (event->xclient.data.l[0] == dpyinfo->Xatom_net_wm_ping
+               /* Handling window stacking changes during
+                  drag-and-drop requires Emacs to select for
+                  SubstructureNotifyMask, which in turn causes the
+                  message to be sent to Emacs itself using the event
+                  mask specified by the EWMH.  To avoid an infinite
+                  loop, make sure the client message's window is not
+                  the root window if DND is in progress.  */
+               && (!x_dnd_in_progress
+                   || !x_dnd_waiting_for_finish
+                   || event->xclient.window != dpyinfo->root_window)
                && event->xclient.format == 32)
              {
                XEvent send_event = *event;
 
                send_event.xclient.window = dpyinfo->root_window;
                XSendEvent (dpyinfo->display, dpyinfo->root_window, False,
-                           /* FIXME: handling window stacking changes
-                              during drag-and-drop requires Emacs to
-                              select for SubstructureNotifyMask,
-                              which in turn causes the message to be
-                              sent to Emacs itself using the event
-                              mask specified by the EWMH.  To avoid
-                              an infinite loop, just use
-                              SubstructureRedirectMask when a
-                              drag-and-drop operation is in
-                              progress.  */
-                           ((x_dnd_in_progress || x_dnd_waiting_for_finish)
-                            ? SubstructureRedirectMask
-                            : SubstructureRedirectMask | SubstructureNotifyMask),
+                           SubstructureRedirectMask | SubstructureNotifyMask,
                            &send_event);
 
                *finish = X_EVENT_DROP;