]> git.eshelyaron.com Git - emacs.git/commitdiff
nndiary.el: fix dodgy schedule code
authorMattias Engdegård <mattiase@acm.org>
Tue, 11 Apr 2023 09:57:07 +0000 (11:57 +0200)
committerMattias Engdegård <mattiase@acm.org>
Tue, 11 Apr 2023 09:57:07 +0000 (11:57 +0200)
* lisp/gnus/nndiary.el (nndiary-last-occurrence):
Don't sort a list and throw away the result because that leaves the
list variable in an undefined state.  Just take the largest element
because that was obviously what the author meant.

lisp/gnus/nndiary.el

index be2bdc9bb15f00b62381544a3d0c8d45bf08fe75..8728aab1def9fc584d0a78cb9fe44474f441b01e 100644 (file)
@@ -1373,10 +1373,10 @@ all.  This may very well take some time.")
                       (setq day (+ 7 day))))
                   ;; Finally, if we have some days, they are valid
                   (when days
-                    (sort days #'>)
                     (throw 'found
                            (encode-time 0 minute hour
-                                        (car days) month year time-zone)))
+                                        (apply #'max days)
+                                         month year time-zone)))
                   )))))
         ;; There's an upper limit, but we didn't find any last occurrence.
         ;; This means that the schedule is undecidable. This can happen if