shr.el (shr-image-displayer): Protect function against non-existent image source.

diff --git a/lisp/gnus/ChangeLog b/lisp/gnus/ChangeLog
index 7d3b2d06835bebbd9ab426bd2b238f5e0aa96e75..b509bc39c76ea862a8a9adcb150b66ceac2a2565 100644 (file)
--- a/lisp/gnus/ChangeLog
+++ b/lisp/gnus/ChangeLog
@@ -1,5 +1,8 @@
 2010-11-17  Katsumi Yamaoka  <yamaoka@jpl.org>
 
+       * shr.el (shr-image-displayer): Protect function against non-existent
+       image source.
+
        * gnus-art.el (gnus-inhibit-images): New user option.
        (gnus-mime-display-single): Don't display image if it is non-nil.
 

diff --git a/lisp/gnus/shr.el b/lisp/gnus/shr.el
index 2dd33ecbc13f2ea185a4700dbde90bd80afe79b8..526f81218913553013f0715a14155d60f5a614e9 100644 (file)
--- a/lisp/gnus/shr.el
+++ b/lisp/gnus/shr.el
@@ -441,19 +441,20 @@ CONTENT-FUNCTION is a function to retrieve an image for a cid url that
 is an argument.  The function to be returned takes three arguments URL,
 START, and END."
   `(lambda (url start end)
-     (if (string-match "\\`cid:" url)
-        ,(when content-function
-           `(let ((image (funcall ,content-function
-                                  (substring url (match-end 0)))))
-              (when image
-                (goto-char start)
-                (shr-put-image image
-                               (prog1
-                                   (buffer-substring-no-properties start end)
-                                 (delete-region start end))))))
-       (url-retrieve url 'shr-image-fetched
-                    (list (current-buffer) start end)
-                    t))))
+     (when url
+       (if (string-match "\\`cid:" url)
+          ,(when content-function
+             `(let ((image (funcall ,content-function
+                                    (substring url (match-end 0)))))
+                (when image
+                  (goto-char start)
+                  (shr-put-image image
+                                 (prog1
+                                     (buffer-substring-no-properties start end)
+                                   (delete-region start end))))))
+        (url-retrieve url 'shr-image-fetched
+                      (list (current-buffer) start end)
+                      t)))))
 
 (defun shr-heading (cont &rest types)
   (shr-ensure-paragraph)