Silence many eshell compilation warnings

* lisp/eshell/em-tramp.el: Adjust requires.
(eshell-parse-command): Autoload.

* lisp/eshell/em-xtra.el: Adjust requires.
(eshell-parse-command): Autoload.

* lisp/eshell/esh-ext.el: Adjust requires.
(eshell-parse-command, eshell-close-handles): Autoload.

* lisp/eshell/esh-io.el: Adjust requires.
(eshell-output-filter): Autoload.

* lisp/eshell/esh-util.el: No need to load tramp when compiling.
(tramp-file-name-structure, ange-ftp-ls, ange-ftp-file-modtime): Declare.
(eshell-parse-ange-ls): Require ange-ftp and tramp.

* lisp/eshell/em-alias.el, lisp/eshell/em-banner.el, lisp/eshell/em-basic.el:
* lisp/eshell/em-cmpl.el, lisp/eshell/em-glob.el, lisp/eshell/em-pred.el:
* lisp/eshell/em-prompt.el, lisp/eshell/em-rebind.el, lisp/eshell/em-smart.el:
* lisp/eshell/em-term.el, lisp/eshell/esh-arg.el, lisp/eshell/esh-mode.el:
* lisp/eshell/esh-opt.el, lisp/eshell/esh-proc.el:
* lisp/eshell/esh-var.el: Adjust requires.

* lisp/eshell/eshell.el: Do not require esh-util twice.
(eshell-add-input-to-history): Declare.
(eshell-command): Check history module is active before using it.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 0f3c16101d39e6ddc67bd2e239bf5133abbbf45b..51f07c517af81d33ac30eb1991fc2ac3dc8cf85a 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,27 @@
 2013-05-23  Glenn Morris  <rgm@gnu.org>
 
+       * eshell/em-tramp.el: Adjust requires.
+       (eshell-parse-command): Autoload.
+       * eshell/em-xtra.el: Adjust requires.
+       (eshell-parse-command): Autoload.
+       * eshell/esh-ext.el: Adjust requires.
+       (eshell-parse-command, eshell-close-handles): Autoload.
+       * eshell/esh-io.el: Adjust requires.
+       (eshell-output-filter): Autoload.
+       * eshell/esh-util.el: No need to load tramp when compiling.
+       (tramp-file-name-structure, ange-ftp-ls, ange-ftp-file-modtime):
+       Declare.
+       (eshell-parse-ange-ls): Require ange-ftp and tramp.
+       * eshell/em-alias.el, eshell/em-banner.el, eshell/em-basic.el:
+       * eshell/em-cmpl.el, eshell/em-glob.el, eshell/em-pred.el:
+       * eshell/em-prompt.el, eshell/em-rebind.el, eshell/em-smart.el:
+       * eshell/em-term.el, eshell/esh-arg.el, eshell/esh-mode.el:
+       * eshell/esh-opt.el, eshell/esh-proc.el:
+       * eshell/esh-var.el: Adjust requires.
+       * eshell/eshell.el: Do not require esh-util twice.
+       (eshell-add-input-to-history): Declare.
+       (eshell-command): Check history module is active before using it.
+
        * eshell/em-ls.el (eshell-ls-dir): Fix -A handling.
 
 2013-05-22  Leo Liu  <sdl.web@gmail.com>

diff --git a/lisp/eshell/em-alias.el b/lisp/eshell/em-alias.el
index aa89177c2dec950a1775cc74974a9ef51505744a..a46b48c01b35cf2023f80cd5b8048de5af7cbe39 100644 (file)
--- a/lisp/eshell/em-alias.el
+++ b/lisp/eshell/em-alias.el
@@ -90,8 +90,6 @@
 
 ;;; Code:
 
-(eval-when-compile
-  (require 'esh-util))
 (require 'eshell)
 
 ;;;###autoload

diff --git a/lisp/eshell/em-banner.el b/lisp/eshell/em-banner.el
index 44928b14e111c6e256468b4c608c189935aa2b45..8c3eebf35100105c2af17aa9a3c67e6c3f43fcfc 100644 (file)
--- a/lisp/eshell/em-banner.el
+++ b/lisp/eshell/em-banner.el
@@ -39,11 +39,11 @@
 ;;; Code:
 
 (eval-when-compile
-  (require 'cl-lib)
-  (require 'esh-mode)
-  (require 'eshell))
+  (require 'cl-lib))
 
 (require 'esh-util)
+(require 'esh-mode)
+(require 'eshell)
 
 ;;;###autoload
 (progn

diff --git a/lisp/eshell/em-basic.el b/lisp/eshell/em-basic.el
index d795b8226caf546940ceb96030bcb2ad95c93924..c440bd0a9287b9f31d7bc0d7341136c7487a6a68 100644 (file)
--- a/lisp/eshell/em-basic.el
+++ b/lisp/eshell/em-basic.el
@@ -59,9 +59,7 @@
 
 ;;; Code:
 
-(eval-when-compile
-  (require 'esh-util))
-
+(require 'esh-util)
 (require 'eshell)
 (require 'esh-opt)
 

diff --git a/lisp/eshell/em-cmpl.el b/lisp/eshell/em-cmpl.el
index 4f4b8dd3276b4b93e94bb2f2550670689cec11fc..426db3232ed1f96df2ab414d1065e2731a62d7c5 100644 (file)
--- a/lisp/eshell/em-cmpl.el
+++ b/lisp/eshell/em-cmpl.el
@@ -70,10 +70,12 @@
 ;;; Code:
 (require 'pcomplete)
 
+(require 'esh-mode)
+(require 'esh-util)
+
 (eval-when-compile
   (require 'cl-lib)
   (require 'eshell))
-(require 'esh-util)
 
 ;;;###autoload
 (progn

diff --git a/lisp/eshell/em-glob.el b/lisp/eshell/em-glob.el
index 866412d252b0446d50cf644ba4d86479a4fbff3b..a58c7730dedc11c1cc037780f9c310d8468db559 100644 (file)
--- a/lisp/eshell/em-glob.el
+++ b/lisp/eshell/em-glob.el
@@ -49,8 +49,8 @@
 
 ;;; Code:
 
-(eval-when-compile (require 'eshell))
 (require 'esh-util)
+(eval-when-compile (require 'eshell))
 
 ;;;###autoload
 (progn

diff --git a/lisp/eshell/em-pred.el b/lisp/eshell/em-pred.el
index 13bdb2e4a0300bc4e03f0cdfb9e2aacd8d7b70e6..3a7f46ebe83793ea6c7b44d950d4a0c5d4e5ce6e 100644 (file)
--- a/lisp/eshell/em-pred.el
+++ b/lisp/eshell/em-pred.el
@@ -46,6 +46,8 @@
 
 ;;; Code:
 
+(require 'esh-util)
+(require 'esh-arg)
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload

diff --git a/lisp/eshell/em-prompt.el b/lisp/eshell/em-prompt.el
index c5429c59bd66d57842918ed68f282546bbaa4902..18731121c4e679c7add950ee5460d9e63ffafc3d 100644 (file)
--- a/lisp/eshell/em-prompt.el
+++ b/lisp/eshell/em-prompt.el
@@ -26,6 +26,7 @@
 
 ;;; Code:
 
+(require 'esh-mode)
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload

diff --git a/lisp/eshell/em-rebind.el b/lisp/eshell/em-rebind.el
index 42a5c36cab32a90c8155ef7edaaf7715f07b2009..341191fc62fa9d22b45c084927d17eb9344bd2c7 100644 (file)
--- a/lisp/eshell/em-rebind.el
+++ b/lisp/eshell/em-rebind.el
@@ -23,6 +23,7 @@
 
 ;;; Code:
 
+(require 'esh-mode)
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload

diff --git a/lisp/eshell/em-smart.el b/lisp/eshell/em-smart.el
index de244a2fb889dc336980b1e9b7f7e397acb2caa6..aa9038aafb96f58da6f10fd20b8e0a1ef6fdc4a1 100644 (file)
--- a/lisp/eshell/em-smart.el
+++ b/lisp/eshell/em-smart.el
@@ -68,6 +68,7 @@
 
 ;;; Code:
 
+(require 'esh-mode)
 (eval-when-compile (require 'eshell))
 
 ;;;###autoload

diff --git a/lisp/eshell/em-term.el b/lisp/eshell/em-term.el
index e659bce05685c5c31c1c4efc97761ed6c69c9019..e5360f2deb47d1fde38bc513a1e172c7e99b79bf 100644 (file)
--- a/lisp/eshell/em-term.el
+++ b/lisp/eshell/em-term.el
@@ -31,6 +31,8 @@
 
 ;;; Code:
 
+(require 'esh-util)
+(require 'esh-ext)
 (eval-when-compile (require 'eshell))
 (require 'term)
 

diff --git a/lisp/eshell/em-tramp.el b/lisp/eshell/em-tramp.el
index c60d0e6395f1f3f26732cea185374cbfb9594f85..fb816b76a7d1a2aa6a082bbe0c63e54e2dc70842 100644 (file)
--- a/lisp/eshell/em-tramp.el
+++ b/lisp/eshell/em-tramp.el
@@ -25,13 +25,13 @@
 
 ;;; Code:
 
+(require 'esh-util)
+
 (eval-when-compile
   (require 'esh-mode)
   (require 'eshell)
   (require 'tramp))
 
-(require 'esh-util)
-
 ;;;###autoload
 (progn
  (defgroup eshell-tramp nil
@@ -53,6 +53,8 @@
        (append '("su" "sudo")
                eshell-complex-commands)))
 
+(autoload 'eshell-parse-command "esh-cmd")
+
 (defun eshell/su (&rest args)
   "Alias \"su\" to call TRAMP.
 

diff --git a/lisp/eshell/em-xtra.el b/lisp/eshell/em-xtra.el
index 7c559772dd3fabf867db6087e51924960d678f8a..c4cab522cf220f30613ed5aceb8cf43ea4fd122e 100644 (file)
--- a/lisp/eshell/em-xtra.el
+++ b/lisp/eshell/em-xtra.el
@@ -23,6 +23,7 @@
 
 ;;; Code:
 
+(require 'esh-util)
 (eval-when-compile
   (require 'eshell)
   (require 'pcomplete))
@@ -40,6 +41,8 @@ naturally accessible within Emacs."
 
 ;;; Functions:
 
+(autoload 'eshell-parse-command "esh-cmd")
+
 (defun eshell/expr (&rest args)
   "Implementation of expr, using the calc package."
   (if (not (fboundp 'calc-eval))

diff --git a/lisp/eshell/esh-arg.el b/lisp/eshell/esh-arg.el
index 73f7fc557e5d42c4bfe5530cfcb6e208de36addc..d7dfd27d8d350a186bc07063afd41ed822e3b619 100644 (file)
--- a/lisp/eshell/esh-arg.el
+++ b/lisp/eshell/esh-arg.el
@@ -27,7 +27,7 @@
 
 (provide 'esh-arg)
 
-(eval-when-compile (require 'eshell))
+(require 'esh-mode)
 
 (defgroup eshell-arg nil
   "Argument parsing involves transforming the arguments passed on the

diff --git a/lisp/eshell/esh-ext.el b/lisp/eshell/esh-ext.el
index 3fe48b26e275f363f3903af202ad75df6949bdd4..c4e4c000bda55cc329fd08abe3f0f665b0f82fa9 100644 (file)
--- a/lisp/eshell/esh-ext.el
+++ b/lisp/eshell/esh-ext.el
@@ -33,10 +33,12 @@
 
 (provide 'esh-ext)
 
+(require 'esh-util)
+
 (eval-when-compile
   (require 'cl-lib)
+  (require 'esh-io)
   (require 'esh-cmd))
-(require 'esh-util)
 (require 'esh-opt)
 
 (defgroup eshell-ext nil
@@ -103,6 +105,8 @@ wholly ignored."
   :type '(choice file (const nil))
   :group 'eshell-ext)
 
+(autoload 'eshell-parse-command "esh-cmd")
+
 (defsubst eshell-invoke-batch-file (&rest args)
   "Invoke a .BAT or .CMD file on DOS/Windows systems."
   ;; since CMD.EXE can't handle forward slashes in the initial
@@ -179,6 +183,8 @@ This bypasses all Lisp functions and aliases."
        (error "%s: external command not found"
               (substring command 1))))))
 
+(autoload 'eshell-close-handles "esh-io")
+
 (defun eshell-remote-command (command args)
   "Insert output from a remote COMMAND, using ARGS.
 A remote command is something that executes on a different machine.

diff --git a/lisp/eshell/esh-io.el b/lisp/eshell/esh-io.el
index 66172c8f6622317ed63031c934f971a42ef34011..4edb47e4758cfa2a078a3a70264d421fe6e030fc 100644 (file)
--- a/lisp/eshell/esh-io.el
+++ b/lisp/eshell/esh-io.el
@@ -58,9 +58,11 @@
 
 (provide 'esh-io)
 
+(require 'esh-arg)
+(require 'esh-util)
+
 (eval-when-compile
-  (require 'cl-lib)
-  (require 'eshell))
+  (require 'cl-lib))
 
 (defgroup eshell-io nil
   "Eshell's I/O management code provides a scheme for treating many
@@ -465,6 +467,8 @@ after all printing is over with no argument."
   (eshell-print object)
   (eshell-print "\n"))
 
+(autoload 'eshell-output-filter "esh-mode")
+
 (defun eshell-output-object-to-target (object target)
   "Insert OBJECT into TARGET.
 Returns what was actually sent, or nil if nothing was sent."

diff --git a/lisp/eshell/esh-mode.el b/lisp/eshell/esh-mode.el
index c22d7c16e98847f5c3084520aa8513378b4678b6..ee857cf20f344b8813157e69b10ff07e6f77231e 100644 (file)
--- a/lisp/eshell/esh-mode.el
+++ b/lisp/eshell/esh-mode.el
@@ -60,7 +60,7 @@
 
 (provide 'esh-mode)
 
-(eval-when-compile (require 'esh-util))
+(require 'esh-util)
 (require 'esh-module)
 (require 'esh-cmd)
 (require 'esh-io)

diff --git a/lisp/eshell/esh-opt.el b/lisp/eshell/esh-opt.el
index 6a37f97bf20838864b65f539fef85b41726ec68e..336254330226597e6566e2a674cdb7ffbbc1a91d 100644 (file)
--- a/lisp/eshell/esh-opt.el
+++ b/lisp/eshell/esh-opt.el
@@ -25,7 +25,7 @@
 
 (provide 'esh-opt)
 
-(eval-when-compile (require 'esh-ext))
+(require 'esh-ext)
 
 ;; Unused.
 ;;; (defgroup eshell-opt nil

diff --git a/lisp/eshell/esh-proc.el b/lisp/eshell/esh-proc.el
index aa630dc87aac62dc47169dfc06920df3cf2a3eef..171d70c0772a005743f39214224febfc191064cb 100644 (file)
--- a/lisp/eshell/esh-proc.el
+++ b/lisp/eshell/esh-proc.el
@@ -25,9 +25,7 @@
 
 (provide 'esh-proc)
 
-(eval-when-compile
-  (require 'eshell)
-  (require 'esh-util))
+(require 'esh-cmd)
 
 (defgroup eshell-proc nil
   "When Eshell invokes external commands, it always does so

diff --git a/lisp/eshell/esh-util.el b/lisp/eshell/esh-util.el
index f9b86219e9ba2ec516e6c0ad3f3961c0490b132a..dd344eb50a2b3f496389f3297007e4bd819b031e 100644 (file)
--- a/lisp/eshell/esh-util.el
+++ b/lisp/eshell/esh-util.el
@@ -605,10 +605,16 @@ If NOSORT is non-nil, the list is not sorted--its order is unpredictable.
     (autoload 'parse-time-string "parse-time"))
 
 (eval-when-compile
-  (require 'ange-ftp nil t)
-  (require 'tramp nil t))
+  (require 'ange-ftp nil t))           ; ange-ftp-parse-filename
+
+(defvar tramp-file-name-structure)
+(declare-function ange-ftp-ls "ange-ftp"
+                 (file lsargs parse &optional no-error wildcard))
+(declare-function ange-ftp-file-modtime "ange-ftp" (file))
 
 (defun eshell-parse-ange-ls (dir)
+  (require 'ange-ftp)
+  (require 'tramp)
   (let ((ange-ftp-name-format
         (list (nth 0 tramp-file-name-structure)
               (nth 3 tramp-file-name-structure)

diff --git a/lisp/eshell/esh-var.el b/lisp/eshell/esh-var.el
index 06858c5b9865615a970c293b9f74bfc2a816c0b6..188b8165248a8ef8451b03847357d71691e6e3c0 100644 (file)
--- a/lisp/eshell/esh-var.el
+++ b/lisp/eshell/esh-var.el
@@ -107,11 +107,11 @@
 
 (provide 'esh-var)
 
-(eval-when-compile
-  (require 'pcomplete)
-  (require 'esh-util)
-  (require 'esh-mode))
+(require 'esh-util)
+(require 'esh-cmd)
 (require 'esh-opt)
+
+(require 'pcomplete)
 (require 'env)
 (require 'ring)
 

diff --git a/lisp/eshell/eshell.el b/lisp/eshell/eshell.el
index a76adb1fd944242d5e173d6c850b44226e2d82f3..9bdf8b3eb68fd385a72e204d1fcdc1cf9bba2942 100644 (file)
--- a/lisp/eshell/eshell.el
+++ b/lisp/eshell/eshell.el
@@ -222,8 +222,7 @@
 ;; things up.
 
 (eval-when-compile
-  (require 'cl-lib)
-  (require 'esh-util))
+  (require 'cl-lib))
 (require 'esh-util)
 (require 'esh-mode)
 
@@ -318,6 +317,8 @@ buffer selected (or created)."
 Modules should use this variable so that they don't clutter
 non-interactive sessions, such as when using `eshell-command'.")
 
+(declare-function eshell-add-input-to-history "em-hist" (input))
+
 ;;;###autoload
 (defun eshell-command (&optional command arg)
   "Execute the Eshell command string COMMAND.
@@ -333,7 +334,8 @@ With prefix ARG, insert output into the current buffer at point."
                                     (eshell-return-exits-minibuffer))
       (unless command
         (setq command (read-from-minibuffer "Emacs shell command: "))
-        (eshell-add-input-to-history command))))
+       (if (eshell-using-module 'eshell-hist)
+           (eshell-add-input-to-history command)))))
   (unless command
     (error "No command specified!"))
   ;; redirection into the current buffer is achieved by adding an