]> git.eshelyaron.com Git - emacs.git/commitdiff
Fix doc-view problem with file names with spaces in them
authorGlenn Morris <rgm@gnu.org>
Wed, 26 Aug 2020 12:37:13 +0000 (14:37 +0200)
committerLars Ingebrigtsen <larsi@gnus.org>
Wed, 26 Aug 2020 12:37:13 +0000 (14:37 +0200)
* lisp/doc-view.el (doc-view-get-bounding-box): Don't bug out on
file names with spaces in them (bug#33344).

lisp/doc-view.el

index 77c06a8eaf9de2e804640b82e2a1ec0f56985aa9..60f6d6350c96972f20a9ea680063a581e5cd7f6e 100644 (file)
@@ -1320,26 +1320,31 @@ dragging it to its bottom-right corner.  See also
 
 (defun doc-view-get-bounding-box ()
   "Get the BoundingBox information of the current page."
-  (let* ((page (doc-view-current-page))
-        (doc (let ((cache-doc (doc-view-current-cache-doc-pdf)))
-               (if (file-exists-p cache-doc)
-                   cache-doc
-                 doc-view--buffer-file-name)))
-        (o (shell-command-to-string
-            (concat doc-view-ghostscript-program
-                    " -dSAFER -dBATCH -dNOPAUSE -q -sDEVICE=bbox "
-                    (format "-dFirstPage=%s -dLastPage=%s %s"
-                            page page doc)))))
-    (save-match-data
-      (when (string-match (concat "%%BoundingBox: "
-                                 "\\([[:digit:]]+\\) \\([[:digit:]]+\\) "
-                                 "\\([[:digit:]]+\\) \\([[:digit:]]+\\)")
-                          o)
-       (mapcar #'string-to-number
-               (list (match-string 1 o)
-                     (match-string 2 o)
-                     (match-string 3 o)
-                     (match-string 4 o)))))))
+  (let ((page (doc-view-current-page))
+       (doc (let ((cache-doc (doc-view-current-cache-doc-pdf)))
+              (if (file-exists-p cache-doc)
+                  cache-doc
+                doc-view--buffer-file-name))))
+    (with-temp-buffer
+      (when (eq 0 (ignore-errors
+                   (process-file doc-view-ghostscript-program nil t
+                                 nil "-dSAFER" "-dBATCH" "-dNOPAUSE" "-q"
+                                 "-sDEVICE=bbox"
+                                 (format "-dFirstPage=%s" page)
+                                 (format "-dLastPage=%s" page)
+                                 doc)))
+       (goto-char (point-min))
+       (save-match-data
+         (when (re-search-forward
+                (concat "%%BoundingBox: "
+                        "\\([[:digit:]]+\\) \\([[:digit:]]+\\) "
+                        "\\([[:digit:]]+\\) \\([[:digit:]]+\\)")
+                 nil t)
+           (mapcar #'string-to-number
+                   (list (match-string 1)
+                         (match-string 2)
+                         (match-string 3)
+                         (match-string 4)))))))))
 
 (defvar doc-view-paper-sizes
   '((a4 595 842)