]> git.eshelyaron.com Git - emacs.git/commitdiff
Don't use the return value of 'push'
authorMattias Engdegård <mattiase@acm.org>
Wed, 4 Dec 2019 10:37:26 +0000 (11:37 +0100)
committerMattias Engdegård <mattiase@acm.org>
Wed, 4 Dec 2019 10:37:26 +0000 (11:37 +0100)
Although 'push' returns the modified list, it isn't actually
documented to do so, so don't rely on it.

* lisp/emacs-lisp/rx.el (rx--translate-any): Add progn.

lisp/emacs-lisp/rx.el

index 6fde27831a0af168da0cb1987c7ec1137db2e3cd..0dc6e198663fae0fbf00d2aa52ee5dbc7f69e697 100644 (file)
@@ -378,7 +378,7 @@ If NEGATED, negate the sense."
                   (let ((class (cdr (assq arg rx--char-classes))))
                     (and class
                          (or (memq class classes)
-                             (push class classes))))))
+                             (progn (push class classes) t))))))
             (t (error "Invalid rx `any' argument: %s" arg))))
     (let ((items
            ;; Translate strings and conses into nonoverlapping intervals,