]> git.eshelyaron.com Git - emacs.git/commitdiff
Add support for module functions to C-h f (Bug#30163).
authorPhilipp Stephani <phst@google.com>
Sun, 28 Jan 2018 20:57:59 +0000 (21:57 +0100)
committerPhilipp Stephani <phst@google.com>
Fri, 2 Feb 2018 19:31:40 +0000 (20:31 +0100)
* lisp/help-fns.el (help-fns-function-description-header): Handle
module functions.

* test/src/emacs-module-tests.el (module/describe-function-1): New
test.

lisp/help-fns.el
test/src/emacs-module-tests.el

index 7a94d2f61ae9f68b4c78b46b4f405967ca4b6b83..a592809de6a6de1a0bb873d439f38a4589062f04 100644 (file)
@@ -642,6 +642,8 @@ Returns a list of the form (REAL-FUNCTION DEF ALIASED REAL-DEF)."
                  (concat beg "Lisp macro"))
                 ((byte-code-function-p def)
                  (concat beg "compiled Lisp function"))
+                 ((module-function-p def)
+                  (concat beg "module function"))
                 ((eq (car-safe def) 'lambda)
                  (concat beg "Lisp function"))
                 ((eq (car-safe def) 'closure)
index a6407524ad7a244418e7f31c62efb87db6cf16dc..05be8383dcc9d5ad30426aa065955417c674c5c8 100644 (file)
@@ -18,6 +18,7 @@
 ;; along with GNU Emacs.  If not, see <https://www.gnu.org/licenses/>.  */
 
 (require 'ert)
+(require 'help-fns)
 
 (defconst mod-test-emacs
   (expand-file-name invocation-name invocation-directory)
@@ -261,4 +262,17 @@ during garbage collection."
       (rx "Module function called during garbage collection\n")
     (mod-test-invalid-finalizer)))
 
+(ert-deftest module/describe-function-1 ()
+  "Check that Bug#30163 is fixed."
+  (with-temp-buffer
+    (let ((standard-output (current-buffer)))
+      (describe-function-1 #'mod-test-sum)
+      (should (equal (buffer-substring-no-properties 1 (point-max))
+                     ;; FIXME: This should print the filename.
+                     "a module function.
+
+(mod-test-sum a b)
+
+Return A + B")))))
+
 ;;; emacs-module-tests.el ends here