]> git.eshelyaron.com Git - emacs.git/commitdiff
Fix display of cursor when 'blink-cursor-delay' has small value
authorEli Zaretskii <eliz@gnu.org>
Fri, 23 Sep 2016 14:25:55 +0000 (17:25 +0300)
committerEli Zaretskii <eliz@gnu.org>
Fri, 23 Sep 2016 14:25:55 +0000 (17:25 +0300)
* lisp/frame.el (blink-cursor-check, blink-cursor-mode):
Protect ourselves against too small values of blink-cursor-delay.
This avoids erratic display of the cursor, or even failure to
display it, when user types text at high speed or leans on a key
to invoke the keyboard auto-repeat feature.  (Bug#24372)

lisp/frame.el

index 09738d1e2ed4d9c123d27fa96f3ea53b671b3781..291150b591bc7b967ebee248b23a0a273e05b27a 100644 (file)
@@ -2115,7 +2115,11 @@ This is done when a frame gets focus.  Blink timers may be stopped by
             (not blink-cursor-idle-timer))
     (remove-hook 'post-command-hook 'blink-cursor-check)
     (setq blink-cursor-idle-timer
-          (run-with-idle-timer blink-cursor-delay
+          ;; The 0.2 sec limitation from below is to avoid erratic
+          ;; behavior (or downright failure to display the cursor
+          ;; during command execution) if they set blink-cursor-delay
+          ;; to a very small or even zero value.
+          (run-with-idle-timer (max 0.2 blink-cursor-delay)
                                blink-cursor-delay
                                'blink-cursor-start))))
 
@@ -2149,7 +2153,11 @@ terminals, cursor blinking is controlled by the terminal."
     (add-hook 'focus-in-hook #'blink-cursor-check)
     (add-hook 'focus-out-hook #'blink-cursor-suspend)
     (setq blink-cursor-idle-timer
-          (run-with-idle-timer blink-cursor-delay
+          ;; The 0.2 sec limitation from below is to avoid erratic
+          ;; behavior (or downright failure to display the cursor
+          ;; during command execution) if they set blink-cursor-delay
+          ;; to a very small or even zero value.
+          (run-with-idle-timer (max 0.2 blink-cursor-delay)
                                blink-cursor-delay
                                #'blink-cursor-start))))