* movemail.c (popmail): Report fchown failure instead of ignoring it.

But if the file already has the right ownership, don't worry about it.

diff --git a/lib-src/ChangeLog b/lib-src/ChangeLog
index d865754cb4075f41676833a753613e9701cf53ca..e0a175e816781f00316804b1a6c8ef224c71a48b 100644 (file)
--- a/lib-src/ChangeLog
+++ b/lib-src/ChangeLog
@@ -1,5 +1,8 @@
 2011-02-21  Paul Eggert  <eggert@cs.ucla.edu>
 
+       * movemail.c (popmail): Report fchown failure instead of ignoring it.
+       But if the file already has the right ownership, don't worry about it.
+
        * make-docfile.c (input_buffer): Rename variables to avoid shadowing.
 
        * movemail.c (main, pop_retr): Rename locals to avoid shadowing.

diff --git a/lib-src/movemail.c b/lib-src/movemail.c
index a5084f27f22dfecd14d2817a7c5937a8c84e8ffe..bc7fa8824e294775b719c51162c01cdb7d99295e 100644 (file)
--- a/lib-src/movemail.c
+++ b/lib-src/movemail.c
@@ -723,7 +723,18 @@ popmail (char *mailbox, char *outfile, int preserve, char *password, int reverse
       error ("Error in open: %s, %s", strerror (errno), outfile);
       return EXIT_FAILURE;
     }
-  fchown (mbfi, getuid (), -1);
+
+  if (fchown (mbfi, getuid (), -1) != 0)
+    {
+      int fchown_errno = errno;
+      struct stat st;
+      if (fstat (mbfi, &st) != 0 || st.st_uid != getuid ())
+       {
+         pop_close (server);
+         error ("Error in fchown: %s, %s", strerror (fchown_errno), outfile);
+         return EXIT_FAILURE;
+       }
+    }
 
   if ((mbf = fdopen (mbfi, "wb")) == NULL)
     {