(vc-bzr-complete-with-prefix): Remove.
authorStefan Monnier <monnier@iro.umontreal.ca>
Mon, 21 Apr 2008 20:49:06 +0000 (20:49 +0000)
committerStefan Monnier <monnier@iro.umontreal.ca>
Mon, 21 Apr 2008 20:49:06 +0000 (20:49 +0000)
(vc-bzr-revision-completion-table): Use completion-table-with-context instead.

lisp/ChangeLog
lisp/vc-bzr.el

index f8ab54a16315e565d58188812140019243ba1961..5bfdcd1a1de20a48e46fcb4466f3db9a6026f68a 100644 (file)
@@ -1,5 +1,9 @@
 2008-04-21  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+       * vc-bzr.el (vc-bzr-complete-with-prefix): Remove.
+       (vc-bzr-revision-completion-table): Use completion-table-with-context
+       instead.
+
        * simple.el (choose-completion-string): Use minibuffer-completion-table.
 
 2008-04-21  Chong Yidong  <cyd@stupidchicken.com>
index 7db90173ee34a1b7b8190363516af7676f8e99e8..fcd1b9b1b5dba7b530ccd00b7adedc37e981edb0 100644 (file)
@@ -706,12 +706,6 @@ Optional argument LOCALP is always ignored."
 
 ;;; Revision completion
 
-(defun vc-bzr-complete-with-prefix (prefix action table string pred)
-  (let ((comp (complete-with-action action table string pred)))
-    (if (stringp comp)
-        (concat prefix comp)
-      comp)))
-
 (defun vc-bzr-revision-completion-table (files)
   (lexical-let ((files files))
     ;; What about using `files'?!?  --Stef
@@ -719,19 +713,20 @@ Optional argument LOCALP is always ignored."
       (cond
        ((string-match "\\`\\(ancestor\\|branch\\|\\(revno:\\)?[-0-9]+:\\):"
                       string)
-        (vc-bzr-complete-with-prefix (substring string 0 (match-end 0))
-                                     action
-                                     'read-file-name-internal
-                                     (substring string (match-end 0))
-                                     ;; Dropping `pred'.   Maybe we should just
-                                     ;; stash it in `read-file-name-predicate'?
-                                     nil))
+        (completion-table-with-context (substring string 0 (match-end 0))
+                                       'read-file-name-internal
+                                       (substring string (match-end 0))
+                                       ;; Dropping `pred'.   Maybe we should
+                                       ;; just stash it in
+                                       ;; `read-file-name-predicate'?
+                                       nil
+                                       action))
        ((string-match "\\`\\(before\\):" string)
-        (vc-bzr-complete-with-prefix (substring string 0 (match-end 0))
-                                     action
-                                     (vc-bzr-revision-completion-table files)
-                                     (substring string (match-end 0))
-                                     pred))
+        (completion-table-with-context (substring string 0 (match-end 0))
+                                       (vc-bzr-revision-completion-table files)
+                                       (substring string (match-end 0))
+                                       pred
+                                       action))
        ((string-match "\\`\\(tag\\):" string)
         (let ((prefix (substring string 0 (match-end 0)))
               (tag (substring string (match-end 0)))
@@ -744,7 +739,7 @@ Optional argument LOCALP is always ignored."
             (goto-char (point-min))
             (while (re-search-forward "^\\(.*[^ \n]\\) +[^ \n]*$" nil t)
               (push (match-string-no-properties 1) table)))
-          (vc-bzr-complete-with-prefix prefix action table tag pred)))
+          (completion-table-with-context prefix table tag pred action)))
 
        ((string-match "\\`\\(revid\\):" string)
         ;; FIXME: How can I get a list of revision ids?