Fix 'apropos-library' for 'define-symbol-props'

* lisp/apropos.el (apropos-library): Sanitize data to avoid
signaling errors when 'define-symbol-props' is seen.  (Bug#72616)

(cherry picked from commit bfe07eca5981fe80ddc8a54b18dd9340ad5ec2be)

diff --git a/lisp/apropos.el b/lisp/apropos.el
index 6c6cd0b593d21cdd59c7b56876d7e01bfab1a657..0655fecd0e88c247d75024cc8de0d3dffa250a12 100644 (file)
--- a/lisp/apropos.el
+++ b/lisp/apropos.el
@@ -734,7 +734,10 @@ the output includes key-bindings of commands."
         ;; FIXME: Print information about each individual method: both
         ;; its docstring and specializers (bug#21422).
         ('cl-defmethod (push (cadr x) provides))
-       (_ (push (or (cdr-safe x) x) symbols))))
+        ;; FIXME: Add extension point (bug#72616).
+       (_ (let ((sym (or (cdr-safe x) x)))
+            (and sym (symbolp sym)
+                 (push sym symbols))))))
     (let ((apropos-pattern "") ;Dummy binding for apropos-symbols-internal.
           (text
            (concat