(read-file-name): Don't let-bind default-directory.

Only abbreviate default-filename if it's a file.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index a50ef0cf512f48812041941ab4a849a1f2b05969..9f4da1f394a20bebc23d59815e06f69bc9b13be5 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,5 +1,8 @@
 2008-04-23  Stefan Monnier  <monnier@iro.umontreal.ca>
 
+       * minibuffer.el (read-file-name): Don't let-bind default-directory.
+       Only abbreviate default-filename if it's a file.
+
        * minibuffer.el (read-file-name-function, read-file-name-predicate)
        (read-file-name-completion-ignore-case, insert-default-directory):
        New vars, moved from fileio.c.

diff --git a/lisp/minibuffer.el b/lisp/minibuffer.el
index 3651aa439bdc885a1942b00989737ae090e379cd..6cef906475e8d93aec1b19f60be57212f86dae5e 100644 (file)
--- a/lisp/minibuffer.el
+++ b/lisp/minibuffer.el
@@ -834,7 +834,8 @@ and `read-file-name-function'."
   ;; If dir starts with user's homedir, change that to ~.
   (setq dir (abbreviate-file-name dir))
   ;; Likewise for default-filename.
-  (setq default-filename (abbreviate-file-name default-filename))
+  (if default-filename
+      (setq default-filename (abbreviate-file-name default-filename)))
   (let ((insdef (cond
                  ((and insert-default-directory (stringp dir))
                   (if initial
@@ -846,17 +847,25 @@ and `read-file-name-function'."
     (if read-file-name-function
         (funcall read-file-name-function
                  prompt dir default-filename mustmatch initial predicate)
-      (let ((default-directory (file-name-as-directory (expand-file-name dir)))
-            (completion-ignore-case read-file-name-completion-ignore-case)
+      (let ((completion-ignore-case read-file-name-completion-ignore-case)
             (minibuffer-completing-file-name t)
             (read-file-name-predicate (or predicate 'file-exists-p))
             (add-to-history nil))
 
         (let* ((val
                 (if (not (next-read-file-uses-dialog-p))
-                    (completing-read prompt 'read-file-name-internal
-                                     nil mustmatch insdef 'file-name-history
-                                     default-filename)
+                    ;; We used to pass `dir' to `read-file-name-internal' by
+                    ;; abusing the `predicate' argument.  It's better to
+                    ;; just use `default-directory', but in order to avoid
+                    ;; changing `default-directory' in the current buffer,
+                    ;; we don't let-bind it.
+                    (lexical-let ((dir (file-name-as-directory
+                                        (expand-file-name dir))))
+                      (minibuffer-with-setup-hook
+                          (lambda () (setq default-directory dir))
+                        (completing-read prompt 'read-file-name-internal
+                                         nil mustmatch insdef 'file-name-history
+                                         default-filename)))
                   ;; If DIR contains a file name, split it.
                   (let ((file (file-name-nondirectory dir)))
                     (when (and default-filename (not (zerop (length file))))