2010-07-01 Mark A. Hershberger <mah@everybody.org>

  * url-http.el (url-http-create-request): Add a CRLF on the end so
  that POSTs with content to https urls work. See
  <https://bugs.launchpad.net/mediawiki-el/+bug/540759>

Prior to this, the following request would not terminate:

(let ((url-request-method "POST")
             (url-request-data "action=login"))
         (url-retrieve-synchronously "https://example.org/wiki/api.php"))

diff --git a/lisp/url/ChangeLog b/lisp/url/ChangeLog
index 4499ea5ff526b752542a8b34c6c9606d11e40e11..1de6f93416a096725761b549e6bf8ea6bbad2f3c 100644 (file)
--- a/lisp/url/ChangeLog
+++ b/lisp/url/ChangeLog
@@ -1,3 +1,9 @@
+2010-07-01  Mark A. Hershberger  <mah@everybody.org>
+
+       * url-http.el (url-http-create-request): Add a CRLF on the end so
+       that POSTs with content to https urls work. See
+       <https://bugs.launchpad.net/mediawiki-el/+bug/540759>
+
 2010-06-22  Mark A. Hershberger  <mah@everybody.org>
 
        * url-parse.el (url-user-for-url, url-password-for-url):

diff --git a/lisp/url/url-http.el b/lisp/url/url-http.el
index 9f988beaf0a343e778c1a3b39443c274f1769d6f..24daba4f77907b308f4f9e353365632403560aa4 100644 (file)
--- a/lisp/url/url-http.el
+++ b/lisp/url/url-http.el
@@ -339,7 +339,7 @@ request.")
              ;; End request
              "\r\n"
              ;; Any data
-             url-http-data))
+             url-http-data "\r\n"))
            ""))
     (url-http-debug "Request is: \n%s" request)
     request))