* lisp/eshell/esh-ext.el (eshell/addpath): Use mapconcat.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 8867ec557e5fe91af755cd5e4c01591f8856e0de..8088a51f59118bdd0964580451cd64e121edf09e 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -21,7 +21,7 @@
 
 2012-08-06  Glenn Morris  <rgm@gnu.org>
 
-       * eshell/esh-ext.el (eshell/addpath): Use dolist.
+       * eshell/esh-ext.el (eshell/addpath): Use dolist and mapconcat.
        Do less getting and setting of environment variables.
 
 2012-08-05  Chong Yidong  <cyd@gnu.org>

diff --git a/lisp/eshell/esh-ext.el b/lisp/eshell/esh-ext.el
index c0add0443cbd7978afbb4db66a4b8b97187e53af..52df1587d5f0449632a39ed7c58dd6fccb683289 100644 (file)
--- a/lisp/eshell/esh-ext.el
+++ b/lisp/eshell/esh-ext.el
@@ -226,12 +226,12 @@ causing the user to wonder if anything's really going on..."
 Adds the given PATH to $PATH.")
    (if args
        (progn
-        (setq eshell-path-env (getenv "PATH"))
-        (dolist (dir (if prepend (nreverse args) args))
-          (setq eshell-path-env
-                (if prepend
-                    (concat dir path-separator eshell-path-env)
-                  (concat eshell-path-env path-separator dir))))
+        (setq eshell-path-env (getenv "PATH")
+              args (mapconcat 'identity args path-separator)
+              eshell-path-env
+              (if prepend
+                  (concat args path-separator eshell-path-env)
+                (concat eshell-path-env path-separator args)))
         (setenv "PATH" eshell-path-env))
      (dolist (dir (parse-colon-path (getenv "PATH")))
        (eshell-printn dir)))))