Fix the OMIT-NULLS + "" case in string-lines

* lisp/subr.el (string-lines): Respect OMIT-NULLS when given an
empty string.

diff --git a/lisp/subr.el b/lisp/subr.el
index aded02c4f7995e83ade7ba96c28b796aaf53b438..ad3494a2fa7a50f72cb26cbff141bebb8cf403a1 100644 (file)
--- a/lisp/subr.el
+++ b/lisp/subr.el
@@ -6748,7 +6748,9 @@ If OMIT-NULLS, empty lines will be removed from the results.
 If KEEP-NEWLINES, don't strip trailing newlines from the result
 lines."
   (if (equal string "")
-      (list "")
+      (if omit-nulls
+          nil
+        (list ""))
     (let ((lines nil)
           (start 0))
       (while (< start (length string))

diff --git a/test/lisp/subr-tests.el b/test/lisp/subr-tests.el
index f4676793ff2c02a7d80607fda3cea65872bf0401..62cf2266d61d70233b5c2d3b6385ca0d28dd34e6 100644 (file)
--- a/test/lisp/subr-tests.el
+++ b/test/lisp/subr-tests.el
@@ -1030,6 +1030,7 @@ final or penultimate step during initialization."))
 
 (ert-deftest test-string-lines ()
   (should (equal (string-lines "") '("")))
+  (should (equal (string-lines "" t) '()))
 
   (should (equal (string-lines "foo") '("foo")))
   (should (equal (string-lines "foo\n") '("foo")))