(auto-revert-tail-handler): Use inhibit-read-only.

Run before-revert-hook.  Suggested by Denis Bueno <denbuen@sandia.gov>.
Use run-hooks rather than run-mode-hooks.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index 047be6d9e9eb8139f8132a094ea243e61eac7863..ca15f733c37e466157102c80461076064afd204f 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,9 @@
+2007-07-06  Stefan Monnier  <monnier@iro.umontreal.ca>
+
+       * autorevert.el (auto-revert-tail-handler): Use inhibit-read-only.
+       Run before-revert-hook.  Suggested by Denis Bueno <denbuen@sandia.gov>.
+       Use run-hooks rather than run-mode-hooks.
+
 2007-07-05  Jay Belanger  <jay.p.belanger@gmail.com>
 
        * calc/calc-comb.el (math-random-digit): Rename to
@@ -16,8 +22,8 @@
 
 2007-07-05  Chong Yidong  <cyd@stupidchicken.com>
 
-       * wid-edit.el (widget-documentation-string-value-create): Insert
-       indentation spaces.
+       * wid-edit.el (widget-documentation-string-value-create):
+       Insert indentation spaces.
 
 2007-07-05  Thien-Thi Nguyen  <ttn@gnuvola.org>
 

diff --git a/lisp/autorevert.el b/lisp/autorevert.el
index 170ca4b88c2443c00880faad13b163d184ebfcca..3831d7c1c050408ca088f90387c2920a99b0740d 100644 (file)
--- a/lisp/autorevert.el
+++ b/lisp/autorevert.el
@@ -447,20 +447,21 @@ This is an internal function used by Auto-Revert Mode."
 (defun auto-revert-tail-handler ()
   (let ((size (nth 7 (file-attributes buffer-file-name)))
        (modified (buffer-modified-p))
-       buffer-read-only                ; ignore
+       (inhibit-read-only t)           ; Ignore.
        (file buffer-file-name)
-       buffer-file-name)               ; ignore that file has changed
+       (buffer-file-name nil))         ; Ignore that file has changed.
     (when (> size auto-revert-tail-pos)
+      (run-hooks 'before-revert-hook)
       (undo-boundary)
       (save-restriction
        (widen)
        (save-excursion
          (goto-char (point-max))
          (insert-file-contents file nil auto-revert-tail-pos size)))
-      (run-mode-hooks 'after-revert-hook)
+      (run-hooks 'after-revert-hook)
       (undo-boundary)
       (setq auto-revert-tail-pos size)
-      (set-buffer-modified-p modified)))
+      (restore-buffer-modified-p modified)))
   (set-visited-file-modtime))
 
 (defun auto-revert-buffers ()
@@ -534,5 +535,5 @@ the timer when no buffers need to be checked."
 
 (run-hooks 'auto-revert-load-hook)
 
-;;; arch-tag: f6bcb07b-4841-477e-9e44-b18678e58876
+;; arch-tag: f6bcb07b-4841-477e-9e44-b18678e58876
 ;;; autorevert.el ends here