Make new menu *Help* output be more resilient

* lisp/help-fns.el (help-fns--insert-menu-bindings): Only insert
the heading if it turns out that we actually find the menu.
(help-fns--insert-bindings): Tweak calling convention.

diff --git a/etc/NEWS b/etc/NEWS
index e97f545dda921a0d1780e727fc93b6e071f7fe79..dc2e7c616a5fe3c3678ef0f5d05791967c6e87eb 100644 (file)
--- a/etc/NEWS
+++ b/etc/NEWS
@@ -434,7 +434,7 @@ following bindings:
 This has been changed to:
 
   It is bound to <open> and C-x C-f.
-  It can also be invoked from the menu: File → Visit New File....
+  It can also be invoked from the menu: File → Visit New File...
 
 +++
 *** The 'C-h .' command now accepts a prefix argument.

diff --git a/lisp/help-fns.el b/lisp/help-fns.el
index 459998016674e6b3e0c98edf23e5ac536d87d24e..67045bb4d671e70f30264fa08419caf07ac1f2fd 100644 (file)
--- a/lisp/help-fns.el
+++ b/lisp/help-fns.el
@@ -565,11 +565,10 @@ the C sources, too."
               (insert "\n"))
             (when menus
               (let ((start (point)))
-                (insert (concat "It can "
-                                (and keys "also ")
-                                "be invoked from the menu: "))
-                (help-fns--insert-menu-bindings menus)
-                (insert ".")
+                (help-fns--insert-menu-bindings
+                 menus
+                 (concat "It can " (and keys "also ")
+                         "be invoked from the menu: "))
                 (fill-region-as-paragraph start (point))))
             (ensure-empty-lines)))))))
 
@@ -582,7 +581,7 @@ the C sources, too."
                     (insert (help--key-description-fontified key)))
                   keys))
 
-(defun help-fns--insert-menu-bindings (menus)
+(defun help-fns--insert-menu-bindings (menus heading)
   (seq-do-indexed
    (lambda (menu i)
      (insert
@@ -593,12 +592,15 @@ the C sources, too."
            (start (point)))
        (seq-do-indexed
         (lambda (entry level)
-          (when (> level 0)
-            (insert
-             (if (char-displayable-p ?→)
-                 " → "
-               " => ")))
-          (let ((elem (assq entry (cdr map))))
+          (when-let ((elem (assq entry (cdr map))))
+            (when heading
+              (insert heading)
+              (setq heading nil))
+            (when (> level 0)
+              (insert
+               (if (char-displayable-p ?→)
+                   " → "
+                 " => ")))
             (if (eq (nth 1 elem) 'menu-item)
                 (progn
                   (insert (nth 2 elem))