]> git.eshelyaron.com Git - emacs.git/commitdiff
Fixup last commit
authorJoão Távora <joaotavora@gmail.com>
Sun, 5 Sep 2021 19:05:45 +0000 (20:05 +0100)
committerJoão Távora <joaotavora@gmail.com>
Sun, 5 Sep 2021 19:05:45 +0000 (20:05 +0100)
Per https://github.com/joaotavora/eglot/issues/726.

I'm still not entirely convinced using all-completion here is a good
idea.  As usual the completion list we get from the server is
pre-filtered to whatever the server wishes.  Letting the completion
style do its own filtering (most completion styles use
completion-regexp-list and all-completions themselves) is completely
useless here.

Let's hope it's not harmful.

* eglot.el (eglot-completion-at-point): Fix all-completions call

lisp/progmodes/eglot.el

index e8b7ffbbb1339977de0edf085f604d6dadb32119..7ebc422451918ac34501c0388b3d14480f635282 100644 (file)
@@ -2371,8 +2371,7 @@ is not active."
                      (filterText (plist-get item :filterText)))
                 (and (or (null pred) (funcall pred proxy))
                      (string-prefix-p
-                      probe (or filterText proxy) completion-ignore-case))))
-            (funcall proxies)))))
+                      probe (or filterText proxy) completion-ignore-case))))))))
        :annotation-function
        (lambda (proxy)
          (eglot--dbind ((CompletionItem) detail kind)