Sync 2007-11-04 change from trunk, plus the related comments that came after.

Don't require rx when compiling.
(tls-end-of-info): Rewrite without using rx.

diff --git a/lisp/ChangeLog b/lisp/ChangeLog
index f4daab758e4693d9fcfbeb96dd3f0c7dacf6d071..624b527c7b926561069facb191783ef30aa1f88d 100644 (file)
--- a/lisp/ChangeLog
+++ b/lisp/ChangeLog
@@ -1,3 +1,8 @@
+2008-03-19  Glenn Morris  <rgm@gnu.org>
+
+       * net/tls.el: Don't require rx when compiling.
+       (tls-end-of-info): Rewrite without using rx.
+
 2008-03-18  Dan Nicolaescu  <dann@ics.uci.edu>
 
        * font-lock.el (font-lock-comment-face): Set the foreground for

diff --git a/lisp/net/tls.el b/lisp/net/tls.el
index 8946b06a3a310c975c4a191807608fb0132ead86..ee8477c3a39043efc1e6371bd44423a284d6a1a0 100644 (file)
--- a/lisp/net/tls.el
+++ b/lisp/net/tls.el
@@ -51,37 +51,25 @@
   (autoload 'format-spec "format-spec")
   (autoload 'format-spec-make "format-spec"))
 
-(eval-when-compile
-  (require 'rx))
-
 (defgroup tls nil
   "Transport Layer Security (TLS) parameters."
   :group 'comm)
 
 (defcustom tls-end-of-info
-  (rx
-   (or
-    ;; `openssl s_client` regexp
-    (sequence
-     ;; see ssl/ssl_txt.c lines 219--220
-     line-start
-     "    Verify return code: "
-     (one-or-more not-newline)
-     "\n"
-     ;; according to apps/s_client.c line 1515 this is always the last
-     ;; line that is printed by s_client before the real data
-     "---\n")
-    ;; `gnutls` regexp
-    (sequence
-     ;; see src/cli.c lines 721--
-     (sequence line-start "- Simple Client Mode:\n")
-     (zero-or-more
-      (or
-       "\n"                             ; ignore blank lines
-       ;; XXX: we have no way of knowing if the STARTTLS handshake
-       ;; sequence has completed successfully, because `gnutls` will
-       ;; only report failure.
-       (sequence line-start "\*\*\* Starting TLS handshake\n"))))))
+  (concat
+   "\\("
+   ;; `openssl s_client' regexp.  See ssl/ssl_txt.c lines 219-220.
+   ;; According to apps/s_client.c line 1515 `---' is always the last
+   ;; line that is printed by s_client before the real data.
+   "^    Verify return code: .+\n---\n\\|"
+   ;; `gnutls' regexp. See src/cli.c lines 721-.
+   "^- Simple Client Mode:\n"
+   "\\(\n\\|"                           ; ignore blank lines
+   ;; According to GnuTLS v2.1.5 src/cli.c lines 640-650 and 705-715
+   ;; in `main' the handshake will start after this message.  If the
+   ;; handshake fails, the programs will abort.
+   "^\\*\\*\\* Starting TLS handshake\n\\)*"
+   "\\)")
   "Regexp matching end of TLS client informational messages.
 Client data stream begins after the last character matched by
 this.  The default matches `openssl s_client' (version 0.9.8c)