Fix failing secrets-test03-items

* test/lisp/net/secrets-tests.el: Use lexical-binding.
(secrets-test03-items): Do not assume :xdg:schema attribute is
silently added to the front of the collection (bug#36694).
(secrets-test04-search, secrets-test-all): Quote function symbols as
such.

diff --git a/test/lisp/net/secrets-tests.el b/test/lisp/net/secrets-tests.el
index c565eba5679aec12823a5b7cd1c5b5324ca02999..bab8eb5d188ae20471fa947b56cf1026030cc749 100644 (file)
--- a/test/lisp/net/secrets-tests.el
+++ b/test/lisp/net/secrets-tests.el
@@ -1,4 +1,4 @@
-;;; secrets-tests.el --- Tests of Secret Service API
+;;; secrets-tests.el --- Tests of Secret Service API -*- lexical-binding: t -*-
 
 ;; Copyright (C) 2018-2019 Free Software Foundation, Inc.
 
@@ -21,6 +21,7 @@
 
 (require 'ert)
 (require 'secrets)
+(require 'seq)
 (require 'notifications)
 
 ;; We do not want chatty messages.
@@ -175,10 +176,9 @@
         (dolist (item `("bar" ,item-path))
          (should
           (string-equal (secrets-get-attribute "session" item :method) "sudo"))
-         ;; The attributes are collected in reverse order.
-         ;; :xdg:schema is added silently.
+          ;; The attribute :xdg:schema is added silently.
          (should
-          (equal
+           (seq-set-equal-p
            (secrets-get-attributes "session" item)
            '((:xdg:schema . "org.freedesktop.Secret.Generic")
               (:host . "remote-host") (:user . "joe") (:method . "sudo")))))
@@ -242,14 +242,14 @@
          (secrets-search-items "session" :xdg:schema "org.gnu.Emacs.foo"))
        (should
         (equal
-         (sort (secrets-search-items "session" :user "joe") 'string-lessp)
+          (sort (secrets-search-items "session" :user "joe") #'string-lessp)
          '("baz" "foo")))
        (should
         (equal
          (secrets-search-items "session":method "sudo" :user "joe") '("foo")))
        (should
         (equal
-         (sort (secrets-search-items "session") 'string-lessp)
+          (sort (secrets-search-items "session") #'string-lessp)
          '("bar" "baz" "foo"))))
 
     ;; Exit.
@@ -261,7 +261,7 @@
   "Run all tests for \\[secrets]."
   (interactive "p")
   (funcall
-   (if interactive 'ert-run-tests-interactively 'ert-run-tests-batch)
+   (if interactive #'ert-run-tests-interactively #'ert-run-tests-batch)
    "^secrets"))
 
 (provide 'secrets-tests)