]> git.eshelyaron.com Git - emacs.git/commitdiff
Fix case when eglot-put-doc-in-help-buffer is nil
authorJoão Távora <joaotavora@gmail.com>
Thu, 9 May 2019 18:49:31 +0000 (19:49 +0100)
committerJoão Távora <joaotavora@gmail.com>
Thu, 9 May 2019 18:49:43 +0000 (19:49 +0100)
* eglot.el (eglot--eldoc-message): Check eglot-put-doc-in-help-buffer.

GitHub-reference: fix https://github.com/joaotavora/eglot/issues/263

lisp/progmodes/eglot.el

index f5d81e4aa4c542f5a693f49ae39eb14f2ed053b4..b9fc25c01e387ad89c729f1bbae7865570dfed3c 100644 (file)
@@ -2075,7 +2075,8 @@ Buffer is displayed with `display-buffer', which obeys
   (when format
     (let ((string (apply #'format format args))) ;; FIXME: overworking?
       (when (or (eq t eglot-put-doc-in-help-buffer)
-                (funcall eglot-put-doc-in-help-buffer string))
+                (and eglot-put-doc-in-help-buffer
+                     (funcall eglot-put-doc-in-help-buffer string)))
         (with-current-buffer (eglot--help-buffer)
           (rename-buffer (format "*eglot-help for %s*" eglot--eldoc-hint))
           (let ((inhibit-read-only t))